feat(QsTile/Dimmer): continue cycle from current strength level #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the DimmerSettingsTile to always start from the dimmest mode if the toch is disabled. Previously it would continue from the last mode, which was confusing to the user, since suddenly the tile acted different when tapped.
Fixes an issue, where if the torch was externally disabled, the mode should continue to show the (now outdated) mode instead of off.
Continues the cycle from the current strength level, by mapping the it to the nearest cycle level. For example, if the user has already enabled the torch through another app, and e.g. set it to 2 (out of 10) the tile will be show the min state.
cyb3rko
force-pushed
the
main
branch
2 times, most recently
from
ab94d4e to
1eda79a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues the cycle from the current strength level by mapping the current level to the next cycle level. For example, if the user has already activated the torch from another application and has set it to 2 (out of 10), the tile will show the minimum state.
Built on/replaces #78