Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rawLink=True breaks lists of values. Bug? #6189

Open
bananasss00 opened this issue Dec 23, 2024 · 1 comment
Open

rawLink=True breaks lists of values. Bug? #6189

bananasss00 opened this issue Dec 23, 2024 · 1 comment
Labels
Potential Bug User is reporting a bug. This should be tested.

Comments

@bananasss00
Copy link

Expected Behavior

The same behavior as with rawLink=False?

Actual Behavior

If a list of images is provided as input and the input parameter rawLink is set to True, then the output will be only the first image from the list.

Steps to Reproduce

workflow:
rawLink.json

{B02E59AC-8533-4E6A-A910-CD316BEE8A29}

test node:

from comfy_execution.graph_utils import GraphBuilder

class rawlinkTrue_test:
    @classmethod
    def INPUT_TYPES(s):
        return {
            "required": {
                "image": ("IMAGE", {'rawLink': True}),
            },
        }

    RETURN_TYPES = ("IMAGE",)
    FUNCTION = "test"
    CATEGORY = "Example"

    def test(self, image):
        graph = GraphBuilder()
        return {
            "result": (image,),
            "expand": graph.finalize(),
        }

class rawlinkFalse_test:
    @classmethod
    def INPUT_TYPES(s):
        return {
            "required": {
                "image": ("IMAGE", {'rawLink': False}),
            },
        }

    RETURN_TYPES = ("IMAGE",)
    FUNCTION = "test"
    CATEGORY = "Example"

    def test(self, image):
        graph = GraphBuilder()
        return {
            "result": (image,),
            "expand": graph.finalize(),
        }


NODE_CLASS_MAPPINGS = {
    "rawlinkTrue_test": rawlinkTrue_test,
    "rawlinkFalse_test": rawlinkFalse_test,
}

Debug Logs

Adding extra search path checkpoints V:/auto1111-webui/models/Stable-diffusion
Adding extra search path configs V:/auto1111-webui/models/Stable-diffusion
Adding extra search path vae V:/auto1111-webui/models/VAE
Adding extra search path loras V:/auto1111-webui/models/Lora
Adding extra search path loras V:/auto1111-webui/models/LyCORIS
Adding extra search path upscale_models V:/auto1111-webui/models/ESRGAN
Adding extra search path upscale_models V:/auto1111-webui/models/RealESRGAN
Adding extra search path upscale_models V:/auto1111-webui/models/SwinIR
Adding extra search path embeddings V:/auto1111-webui/models/embeddings
Adding extra search path hypernetworks V:/auto1111-webui/models/hypernetworks
Adding extra search path controlnet V:/auto1111-webui/models/ControlNet
Total VRAM 16376 MB, total RAM 130998 MB
pytorch version: 2.5.1+cu124
xformers version: 0.0.28.post3
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 4080 : cudaMallocAsync
Using sage attention
Setting temp directory to: a:\comfyui-temp\temp
[Prompt Server] web root: V:\comfyu_py311\ComfyUI\web
V:\comfyu_py311\python_embeded\Lib\site-packages\kornia\feature\lightglue.py:44: FutureWarning: `torch.cuda.amp.custom_fwd(args...)` is deprecated. Please use `torch.amp.custom_fwd(args..., device_type='cuda')` instead.
  @torch.cuda.amp.custom_fwd(cast_inputs=torch.float32)
### Loading: ComfyUI-Impact-Pack (V8.1.5)
[WARN] ComfyUI-Impact-Pack: `ComfyUI` or `ComfyUI-Manager` is an outdated version.

Import times for custom nodes:
   0.0 seconds: V:\comfyu_py311\ComfyUI\custom_nodes\rawlink_test.py
   0.1 seconds: V:\comfyu_py311\ComfyUI\custom_nodes\ComfyUI-Impact-Pack

Starting server

To see the GUI go to: http://127.0.0.1:8188
[Impact Pack] Wildcards loading done.
got prompt
Prompt executed in 0.35 seconds

Other

No response

@bananasss00 bananasss00 added the Potential Bug User is reporting a bug. This should be tested. label Dec 23, 2024
@bananasss00 bananasss00 changed the title rawLink=True breaks lists of values rawLink=True breaks lists of values. Bug? Dec 23, 2024
@bananasss00
Copy link
Author

With rawLink=True, the input list of images is unpacked into individual elements

class rawlinkTrue2_test:
    @classmethod
    def INPUT_TYPES(s):
        return {
            "optional": {
                "image": ("IMAGE", {'rawLink': True}),
            },
        }

    RETURN_TYPES = ("IMAGE","IMAGE","IMAGE","IMAGE","IMAGE")
    FUNCTION = "test"
    CATEGORY = "Example"

    def test(self, image=None):
        graph = GraphBuilder()
        return {
            "result": (image,),
            "expand": graph.finalize(),
        }

workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Potential Bug User is reporting a bug. This should be tested.
Projects
None yet
Development

No branches or pull requests

1 participant