You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Any model and LoRA is usable to reproduce this issue.
1) Result using 1 SamplerCustomAdvanced node, with hooks
2) Result using 2 SamplerCustomAdvanced nodes, with hooks (expected to match with result 1)
3) Result using 1 or 2 SamplerCustomAdvanced nodes, without hooks (matches as expected)
The last result in this list can be obtained by bypassing the Set CLIP Hooks node. (Ctrl + B)
Debug Logs
n/a
Other
A use case of a workflow like this, though not shown in this workflow in order to keep things straightforward, would be to sample for a longer duration in high sigma values, or to flip the latent halfway through sampling.
I've also mentioned in this issue title that hooks seem disabled in the first step based on what the sampling preview produces, and also the brief lag after 1 step is performed in the second SamplerCustomAdvanced node (which does not occur when hooks are disabled).
Version info
The text was updated successfully, but these errors were encountered:
catboxanon
changed the title
Hooks seemingly disabled at first step of a second SamplerCustomAdvanced node
Hooks disabled at first step of a second SamplerCustomAdvanced node
Dec 23, 2024
Progress output looks something like this in the console. The expectation would be only 1.0 is printed at step 0 (first step) of sampling, not tensor(0.) at step 0 followed by 1.0 at step 1 (after one step has already been completed).
Note I adjusted the end_percent value to 0.1 in the Create Hook Keyframes Interp node to make it more clear that the hook is supposed to "finish" during the first sampling pass.
Expected Behavior
Results are identical when a hook LoRA is enabled and multiple
SamplerCustomAdvanced
nodes are used.Actual Behavior
Results are not identical when a hook LoRA is enabled and multiple
SamplerCustomAdvanced
nodes are used. They are only identical if no hook is used.Steps to Reproduce
See workflow: hook-test.json
Any model and LoRA is usable to reproduce this issue.
1) Result using 1 SamplerCustomAdvanced node, with hooks
2) Result using 2 SamplerCustomAdvanced nodes, with hooks (expected to match with result 1)
3) Result using 1 or 2 SamplerCustomAdvanced nodes, without hooks (matches as expected)
The last result in this list can be obtained by bypassing the
Set CLIP Hooks
node. (Ctrl + B
)Debug Logs
n/a
Other
A use case of a workflow like this, though not shown in this workflow in order to keep things straightforward, would be to sample for a longer duration in high sigma values, or to flip the latent halfway through sampling.
I've also mentioned in this issue title that hooks seem disabled in the first step based on what the sampling preview produces, and also the brief lag after 1 step is performed in the second
SamplerCustomAdvanced
node (which does not occur when hooks are disabled).Version info
The text was updated successfully, but these errors were encountered: