Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use portable modifiers/attributes from llvm/Support/Compiler.h #14

Open
simoll opened this issue Jan 25, 2018 · 0 comments
Open

Use portable modifiers/attributes from llvm/Support/Compiler.h #14

simoll opened this issue Jan 25, 2018 · 0 comments
Labels
enhancement

Comments

@simoll
Copy link
Member

simoll commented Jan 25, 2018

RV's implementation uses GCC/Linux-specific features that will not compile on other systems (eg __attribute__((noreturn)) with MSVC, see #13).

The LLVM header llvm/Support/Compiler.h provides portable modifiers/attributes that work on all compilers that LLVM supports. We should use those macros were possible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simoll