Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blue Selection trigged when List (Blur) Selection expected #19

Open
carson-katri opened this issue Jun 8, 2020 · 2 comments
Open

Blue Selection trigged when List (Blur) Selection expected #19

carson-katri opened this issue Jun 8, 2020 · 2 comments
Labels
good first issue Good for newcomers macOS Only This issue only occurs on macOS

Comments

@carson-katri
Copy link
Owner

NavigationLink and List selection state seem to be overlapping.

There are two ways this happens:

    • select a post
    • see the post now has a grey selected background
    • tap section header
    • see the selected post now has a blue selected background
    • all consecutive selections will have a blue background as well
  1. Click on the edge of the list item (outside the text or images)

Perhaps make the click area fill the space so that clicking on the edge won't cause a selection.

@carson-katri carson-katri added macOS Only This issue only occurs on macOS good first issue Good for newcomers labels Jun 8, 2020
@srinikhil-07
Copy link

srinikhil-07 commented Jul 27, 2020

Screen Shot 2020-07-27 at 12 27 12 PM

@carson-katri Is this the issue you described?
Seems like highlighting is stuck on first selection on the List I make and subsequent selections of topics aren't highlighted as seen.

Can you please suggest any starting point to look into this issue, I will try fixing this.

@carson-katri
Copy link
Owner Author

@Nikhil0487 I'd start in PostList.swift. There you'll see the code that handles the selection state for both NavigationLink and List. I believe the issue is that they both have selection states independent from one another, which is leading to issues with both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers macOS Only This issue only occurs on macOS
Projects
None yet
Development

No branches or pull requests

2 participants