Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multi-hints.js] not work on firefox46 #13

Open
kesdoputr opened this issue Apr 29, 2016 · 4 comments
Open

[multi-hints.js] not work on firefox46 #13

kesdoputr opened this issue Apr 29, 2016 · 4 comments

Comments

@kesdoputr
Copy link

Just upgrade to firefox 46 and vimperator 3.13 and found multi-hints.js can't work.
This plugin is very useful,can you fix it?Thanks for your reply.

@caisui
Copy link
Owner

caisui commented Apr 29, 2016

Thank you for reporting. I fix it.

// I use Firefox ESR...

@kesdoputr
Copy link
Author

kesdoputr commented Apr 29, 2016

Thanks for the soon fix.Now it wokrs great.
And i have a question before,that can i modify the description for actions?
It's not a big question and don't affect for use just i want to see the description for the action.
Like the picture below,i want to show follow link and yank locations,not //a and //*[@href]
https://i.imgur.com/D79PnKw.jpg
https://i.imgur.com/E2cqNte.jpg

@caisui
Copy link
Owner

caisui commented Apr 30, 2016

add to action description to prompt.
If you wanto show only action descript, please apply bellow patch.

diff --git a/plugin/multi-hints.js b/plugin/multi-hints.js
index 96391ae..0ac2763 100755
--- a/plugin/multi-hints.js
+++ b/plugin/multi-hints.js
@@ -241,7 +241,7 @@ xml`<plugin name="multi-hints" version="0.0.2"
             commandline.close();
         }
         commandline.setTimeout(function () {
-            commandline.input(`${cmd.desc}[${util.clip(selector, 16)}]`, function (arg){
+            commandline.input(`${cmd.desc}`, function (arg){
                 let args = [];
                 let list = hints._pageHints;
                 let matcher = new MulitHintMatcher(arg);

@kesdoputr
Copy link
Author

I apply the patch and that's what i want.
Thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants