Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent sorting - make more obvious #286

Open
mdancho84 opened this issue Feb 9, 2024 · 2 comments
Open

Inconsistent sorting - make more obvious #286

mdancho84 opened this issue Feb 9, 2024 · 2 comments

Comments

@mdancho84
Copy link
Contributor

Thinking of adding a sort parameter to these functions to make it more obvious to what's happening under the hood.

One issue is that when sorting, the order of the groups are changing. So maybe make this optional.

@mdancho84
Copy link
Contributor Author

Switched from using data.apply(lambda x: x) to data.obj.copy(). The former sorts groups alphabetically. The latter maintains the order of the original data.

@mdancho84
Copy link
Contributor Author

Next on my list is to tackle these. Make them optional with sort = True as default.

 df.sort_values(by=[*group_names, date_column], inplace=True)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant