You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Many things are in the disabled items list, even though they are valid, and are actually being sold in AH on "real" servers.
In my fork I have imported a list of item prices from Auctioneer addon data from a very big server, so items that are sold in the real world.
Using that to filter the disabled items list, I find that there are about 270 items in the disabled list, that are actually being sold in real AH's.
Using this to keep a list of wrong things.
These are just normal fish. I was already confused why I can sell Mud Snappers on auction house, but Smallfish I can't, even though they are both fished together in the same region.
The Oily Blackmouth is even an alchemy trade good, which is quite useful.
One note, the subclass 0 ones are rare fishes. But they can still be sold (and usually for quite high prices)
I have also included some rare fish (like 21 pound lobster, 32 pound salmon, 103 pound mightfish) that don't have a price in my data, but that is simply because they are so ultra rare, not because they are unavailable
I think we should clean up the disabled list.
Sort things by categories (Like "Depreacated prefix") and such.
And also instead of just hardcoding a list, do it using queries. For example we can Query for items with Flags&0x10, to get all items already flagged as deprecated. Then we don't need to list them separately.
ITEM_FLAG_DEPRECATED is 1595 items
ITEM_FLAG_CONJURED is 114 items
(Excluding the flag checks above)
item_template.name LIKE '%DEPRECATED%' 17 items
item_template.name LIKE '[PH]%' 103 items
item_template.name LIKE '%deprecated%' 14 items
item_template.name LIKE '%test%' 72 items
item_template.name LIKE 'QA%' 25 items
item_template.name LIKE 'zzOLD%' 26 items
item_template.name LIKE 'CRobinson%' 14 items
bonding = 1 is 2501 items (even though we have separate config option to disable BOP items)
class=15 & subclass=0 & description!="" & item_template.name LIKE '% Coin' 53 items (dalaran fountain coins) (40 of these are already disabled, somehow we're missing a few)
With these, that leaves about 1200 items to manually disable (instead of the previous 4500)
Expected Behaviour
Items that are commonly sold should not be disabled.
Steps to reproduce the problem
Use the normal SQL setup files.
Extra Notes
No response
AC rev. hash/commit
AC fd2869f283fddb7190c9202f2e859747c7150cb7
Operating system
Debian
Custom changes or Modules
No response
The text was updated successfully, but these errors were encountered:
Current Behaviour
Many things are in the disabled items list, even though they are valid, and are actually being sold in AH on "real" servers.
In my fork I have imported a list of item prices from Auctioneer addon data from a very big server, so items that are sold in the real world.
Using that to filter the disabled items list, I find that there are about 270 items in the disabled list, that are actually being sold in real AH's.
Using this to keep a list of wrong things.
These are just normal fish. I was already confused why I can sell Mud Snappers on auction house, but Smallfish I can't, even though they are both fished together in the same region.
The Oily Blackmouth is even an alchemy trade good, which is quite useful.
One note, the subclass 0 ones are rare fishes. But they can still be sold (and usually for quite high prices)
I have also included some rare fish (like 21 pound lobster, 32 pound salmon, 103 pound mightfish) that don't have a price in my data, but that is simply because they are so ultra rare, not because they are unavailable
Enchanting supplies?? Ref #73
Tradegoods - Leather
Tradegoods - Ore
Tradegoods - Herb
Tradegoods - Other
Consumable - Food&Drink
Some other misc things (That are definitely sold in real AH's, I actually have prices for all these, exported from Auctioneer data)
I think we should clean up the disabled list.
Sort things by categories (Like "Depreacated prefix") and such.
And also instead of just hardcoding a list, do it using queries. For example we can Query for items with Flags&0x10, to get all items already flagged as deprecated. Then we don't need to list them separately.
(Excluding the flag checks above)
item_template.nameLIKE '%DEPRECATED%'17 itemsitem_template.nameLIKE '[PH]%'103 itemsitem_template.nameLIKE '%deprecated%'14 itemsitem_template.nameLIKE '%test%'72 itemsitem_template.nameLIKE 'QA%'25 itemsitem_template.nameLIKE 'zzOLD%'26 itemsitem_template.nameLIKE 'CRobinson%'14 itemsitem_template.nameLIKE '% Coin'53 items (dalaran fountain coins) (40 of these are already disabled, somehow we're missing a few)With these, that leaves about 1200 items to manually disable (instead of the previous 4500)
Expected Behaviour
Items that are commonly sold should not be disabled.
Steps to reproduce the problem
Use the normal SQL setup files.
Extra Notes
No response
AC rev. hash/commit
AC fd2869f283fddb7190c9202f2e859747c7150cb7
Operating system
Debian
Custom changes or Modules
No response
The text was updated successfully, but these errors were encountered: