Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycle time #122

Open
shandshellin opened this issue Nov 15, 2024 · 8 comments
Open

Cycle time #122

shandshellin opened this issue Nov 15, 2024 · 8 comments

Comments

@shandshellin
Copy link

When is the cycle ran, how often does it run Itemspercycle?

@shandshellin
Copy link
Author

does cycle mean it runs only when the server is rebooted?

@AldebaraanMKII
Copy link

AldebaraanMKII commented Nov 19, 2024

Once a minute. But it will only add items if the current auctions for a faction is under the max value for that faction.

@spiffynacho
Copy link

I am only seeing the server fill to the max value when the server boots. It does not run continue to run after reaching the maximum number of items.

@kewinrausch
Copy link

The buy\sell cycle gets called periodically; if you enable debug logging you can see it happens on the server console.

@LannyE
Copy link

LannyE commented Nov 27, 2024

I am having the same issue as spiffynacho and shandshellin. The auction house only refills after a server restart. I have been running the AH-Bot for many years and only noticed this happening in the last 2-3 months. It does tick every minute to buy items but for some reason will not restock until the server restarts. On server restart it will tick about every minute to restock with the amount it is allowed per tick until it reaches the max.

@kewinrausch
Copy link

The refill depends on many variables. The algorithm right now works by doing ItemsPerCycle attempts at each round. Each attempt means taking a possible candidate. If the candidate is not valid for some reason, the attempt is burned and you got ItemsPerCycle - 1 attempts now. The name of the variable is misleading, but its like that for compatibility purposes.

  • If there are some filters in place, the filter can exclude item insertion, and that an attempts lost.
  • If you want copper and copper is not refilled, it means that the bot selected another item to include, so it's possible to have duplicates in the market.
  • If you put a limit to the possible duplicates but you have the entire set of items, then the possibility to obtain copper again it low and depends on the max amount of item to be sold. If the possible pool of items is 10000, the possibility to pick an item is 1/10000.

If you want a set of items to be always available, use the whitelist configuration and only insert those items you want to be sold. This way the bot as way less items to select and will keep in the market only those has been authorized. If you pick 1000 items and set the maxitems to 1000, they will be always preserved in the market.

@LannyE
Copy link

LannyE commented Dec 6, 2024

@kewinrausch I appreciate your response, but I am not sure how that explains the issue we are having. Say I have 12000 as the maxitems upon server restart the AH will refill up to the 12000 limit. About 12 hours later auctions will end and they will decrease so by the time about 14 hours has passed since server restart I will have only about 8000 items left in the AH. It will not restock at all. If at that point I restart the server the AH will restock back up to the 12000 limit. I enabled the debug and it is saying this for all auction houses:
image

You talk of invalid items burning an attempt during a round but the debug doesn't show that nor would that explain why a server restart would list everything back up to the max if invalid items existed. As I said earlier, I appreciate your response and guidance on this.

@LaertesKrabs
Copy link

LaertesKrabs commented Dec 9, 2024

@LannyE can confirm, AH only gets refilled at server start or if you reload the config via command

Edit: Did some research. I manually deleted all auctions with the ahexpire command. There is a difference in BinEmpty:

ahbot1

First Screenshot is without reloading the config

ahbot2

Second is after reloading the config (or server restart)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants