Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages contain invalid peer dependency to @material-ui/labs #28

Closed
DavidNepozitek opened this issue Jan 3, 2025 · 2 comments · Fixed by #29
Closed

Packages contain invalid peer dependency to @material-ui/labs #28

DavidNepozitek opened this issue Jan 3, 2025 · 2 comments · Fixed by #29

Comments

@DavidNepozitek
Copy link

The Issue

The JS packages spicedb-common and playground-ui contain peer dependency to @material-ui/labs, which does not exist and is not used in the project: https://github.com/search?q=repo%3Aauthzed%2Fplayground+%40material-ui%2Flabs&type=code

Why is it a problem

The new versions of package managers install the peer dependencies, by default, if not explicitly overridden by a flag (https://github.com/npm/rfcs/blob/main/implemented/0025-install-peer-deps.md). This causes an error when installing a package that references spicedb-common or playground-ui ('@material-ui/labs@^4.11.2' is not in this registry.).

Solution

I believe the intention was to target the @material-ui/lab. So it is sufficient to replace the corresponding lines to:
"@material-ui/lab": "^4.0.0-alpha.61".

@tstirrat15
Copy link
Contributor

@DavidNepozitek I pushed a change in #29. Does it solve the issue?

@DavidNepozitek
Copy link
Author

@tstirrat15 Hi, thanks for the quick resolution! I've tested it and it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants