Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Do not pass rows that contains Step.inputs with None values #1035

Open
gabrielmbmb opened this issue Oct 12, 2024 · 0 comments
Open
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@gabrielmbmb
Copy link
Member

Is your feature request related to a problem? Please describe.
Let's say that I have a pipeline like:

TextGeneration() >> ProcessGeneration()

TextGeneration will add a generation to the output dictionary, but if the LLM fails the generation will contain None.ProcessGeneration.inputs are ["generation"], but as TextGeneration can produce None values, ProcessGeneration will have to handle None values. This applies to all the Steps, which is a bit cumbersome.

Describe the solution you'd like
_StepWrapper could check the inputs columns of the Step and check that the input dictionaries contain non-None values for these keys (Step.inputs). If they do, then these dictionaries are not passed to the Step and imputed.

@gabrielmbmb gabrielmbmb added the enhancement New feature or request label Oct 12, 2024
@gabrielmbmb gabrielmbmb added this to the 1.5.0 milestone Oct 12, 2024
@gabrielmbmb gabrielmbmb self-assigned this Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant