-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flaky Test: ClientEffectiveStrategyTest #2245
Comments
https://github.com/apple/servicetalk/pull/2254/checks?check_run_id=6941365663
|
https://github.com/apple/servicetalk/runs/7156620156
|
https://github.com/apple/servicetalk/runs/7158092150
|
https://github.com/apple/servicetalk/runs/7158091706
|
https://github.com/apple/servicetalk/pull/2257/checks?check_run_id=7158336577
|
https://github.com/apple/servicetalk/runs/7815903522 (snapshot build)
|
https://github.com/apple/servicetalk/pull/2348/checks?check_run_id=8310753563 |
https://github.com/apple/servicetalk/pull/2440/checks?check_run_id=9676646223
|
https://github.com/apple/servicetalk/pull/2444/checks?check_run_id=9677905936
|
https://github.com/apple/servicetalk/pull/2520/checks?check_run_id=11633533654
|
https://github.com/apple/servicetalk/pull/2555/checks?check_run_id=12913256561
|
https://github.com/apple/servicetalk/pull/2614/checks?check_run_id=13905833089
|
https://github.com/apple/servicetalk/pull/2640/checks?check_run_id=14783343570
|
https://github.com/apple/servicetalk/runs/16047242078
|
https://github.com/apple/servicetalk/pull/2678/checks?check_run_id=16074782218
|
https://github.com/apple/servicetalk/pull/2684/checks?check_run_id=16351475169
|
https://github.com/apple/servicetalk/pull/2690/checks?check_run_id=16697253580
|
https://github.com/apple/servicetalk/pull/2737/checks?check_run_id=18060199944
|
@bryce-anderson thanks - good to understand that the last flaky test fixes did not help with this. looking. |
Another failure
The output didn't seem to contain a suppressed exception. |
https://github.com/apple/servicetalk/pull/2769/checks?check_run_id=19163365328
|
https://github.com/apple/servicetalk/actions/runs/10959243976/job/30431175672?pr=3061#step:8:1437
|
https://github.com/apple/servicetalk/actions/runs/10966985327/job/30455933910?pr=3062#step:8:1051
|
Failed multiple times in a row for a single PR: https://github.com/apple/servicetalk/actions/runs/11127685633/job/30931918614?pr=3071
|
Another PR:
|
Another in the nightly runs:
|
I'm concerned that this test is surfacing some of the inherent race behaviors in our async streams. This is a general idea, but we tend to queue events in our async-streams when another thread has 'taken the lock' so to speak, and that causes events to end up being run by threads that didn't submit them. This is tangentially what's happening in #1894. If that's the case, fixing it will be really involved (we'd need to re-think the queue system). In the meantime, I think we should consider disabling this test unless someone has some better ideas for how to debug/de-flake it. |
Motivation: We had previously disabled the clientStrategy test because it's flaky. According to the notes in the issue (apple#2245) it is only in one part, and that is in the Send stage which appears to be offloaded when it shouldn't be. Modifications: Re-enable the test and prune those errors, and log them.
Motivation: We had previously disabled the clientStrategy test because it's flaky. According to the notes in the issue (apple#2245) it is only in one part, and that is in the Send stage which appears to be offloaded when it shouldn't be. Modifications: Re-enable the test and prune those errors, and log them.
…3105) Motivation: We had previously disabled the clientStrategy test because it's flaky. According to the notes in the issue (#2245) it is only in one part, and that is in the Send stage which appears to be offloaded when it shouldn't be. Modifications: Re-enable the test and prune those errors, and log them.
Another pop: https://github.com/apple/servicetalk/actions/runs/12204191501/job/34048759889?pr=3131#step:8:963
|
https://github.com/apple/servicetalk/actions/runs/12438687624/job/34731061698?pr=3152
|
https://github.com/apple/servicetalk/pull/2244/checks?check_run_id=6799736339
The text was updated successfully, but these errors were encountered: