fix: add full_match_handler.go to convert the query. #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NoyException Is this issue the final obstacle to making the C# client functional? If so, we should consider enabling the test in this PR. |
I'll enable it. |
This is only the current obstacle, not the last one... |
…c once per statement.
# Conflicts: # pgserver/stmt.go
TianyuZhang1214
requested review from
fanyang01,
NoyException and
VWagen1989
fanyang01
reviewed
Dec 25, 2024
# Conflicts: # flightsqltest/driver_test.go
fanyang01
reviewed
Dec 26, 2024
…7-ambiguous-reference
|
@fanyang01 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issues #297 and #316, addressing compatibility challenges with Npgsql in C#.
Issue 1: Real Data for PostgreSQL System Tables
In PostgresDatabaseInfo.cs, 4 hard-coded queries are executed, with the results accessed via
ReadNonNullableString. To ensure compatibility and non-null results, real PostgreSQL system table data are mirrored in MyDuck Server. Additionally, all PostgreSQL system table queries are redirected to their corresponding__sys__.pg_xxxtables in DuckDB.Issue 2: Discontinuous Data in Batches
As discussed in #316, query results are split into multiple batches and returned discontinuously due to each batch containing a separate
RowDescription. This PR introduces a mechanism to ensure that only a singleRowDescriptionis returned per statement execution, providing a continuous result stream for better compatibility with Npgsql.