Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users can not tag a saved query if using bulk select #27988

Open
3 tasks done
EddyBess opened this issue Apr 11, 2024 · 6 comments · May be fixed by #31631
Open
3 tasks done

Users can not tag a saved query if using bulk select #27988

EddyBess opened this issue Apr 11, 2024 · 6 comments · May be fixed by #31631
Labels
#bug Bug report preset:bounty:bug Bugs that have been selected by Preset and have a bounty attached. preset:bounty Issues that have been selected by Preset and have a bounty attached.

Comments

@EddyBess
Copy link

EddyBess commented Apr 11, 2024 •
edited
Loading

Bug description

When I create a saved query with a non admin user and try to tag it using the bulk select option I get the following error :

1 items could not be tagged because you don’t have edit permissions to all selected objects.

Am I missing the permission that should allow the tagging on the saved query from bulk select ?
Any help would be very appreciated !

How to reproduce the bug

With a non admin user

  1. Create a saved query
  2. Go to saved query tab
  3. Click bulk select
  4. Select the created query
  5. Click Add Tag
  6. Add any tag

Screenshots/recordings

image
image
image

Superset version

4.0.0

Python version

3.10

Node version

16

Browser

Chrome

Additional context

However I can edit/delete the saved query.

When trying to tag chart or dashboard using the bulk select it is working fine.

When trying to tag the query from the Tag object it is working fine.

When using an admin I do not encounter this problem.

Non admin users have the following roles :

  • Gamma
  • Sqllab
  • 3LC_User (Custom role I have created)
    List of permissions in 3LC_User Role :
    [can read on Dataset, can write on Dataset, can read on Query, can get or create dataset on Dataset, can warm up cache on Dataset, can export on Dataset, can duplicate on Dataset, can activate on TabStateView, can delete query on TabStateView, can migrate query on TabStateView, menu access on Manage]

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
@mistercrunch mistercrunch added the #bug Bug report label Apr 17, 2024
@hughhhh hughhhh self-assigned this Apr 24, 2024
@yousoph
Copy link
Member

yousoph commented Dec 9, 2024 •
edited
Loading

This issue still exists, but now the error message shows as the following:

image

Note that you'll need to have the feature flag TAGGING_SYSTEM enabled and create a tag in the Tags page (in Settings) first before going through the repro steps listed in the ticket

@geido
Copy link
Member

geido commented Dec 23, 2024

🎉 Preset Bounty Available: $100 USD 🎉

To claim this bounty, please carefully follow the steps below.

📋 Steps to Participate

  1. Review Guidelines:
    Read through the Preset Bounty Program Contribution Guide for complete details on bounty requirements.

  2. Show Your Interest:
    Complete the Preset Bounty Program Survey and comment this issue to express your interest.

  3. Join the Slack Channel:
    After completing the survey, you’ll receive an invitation to the dedicated Apache Superset Slack channel.

  4. Get Assigned:
    To officially start, ensure a Bounty Program Manager has assigned you to this issue.

  5. Submit Your Solution:
    When ready, submit your solution with the Fixes #{issue_number} notation in your Pull Request description.

  6. Claim Your Bounty:
    Sign up at GitPay.me and submit your solution via: https://gitpay.me/#/task/1030

💡 Additional Notes

  • Only developers assigned by a Bounty Program Manager should start working on this issue to win the bounty.
  • Be sure to follow the guide closely to avoid any delays in payment. Please, allow a few days after your PR has been merged for the bounty to be released.

Good luck, and happy coding! 🎉

@geido geido added preset:bounty Issues that have been selected by Preset and have a bounty attached. preset:bounty:bug Bugs that have been selected by Preset and have a bounty attached. labels Dec 23, 2024
@b4s36t4
Copy link

b4s36t4 commented Dec 23, 2024

Would love to work on this issue, can I get assigned?

@EddyBess
Copy link
Author

Hey, I created this is issue back in the days for Apache Superset v.4.0, I thought that it was fixed in Superset 4.1. However due to requirements the company I am working for is only using v4.0 and did not upgrade to 4.1. I already fixed this bug in local and would be happy to contribute and to fix it to the main branch

@LevisNgigi
Copy link
Contributor

Hey, would love to work on this.was looking at it a while back. Yousoph's issue is solved on my end but what remained was the issue with non-admin users not being able to tag a query.

@geido
Copy link
Member

geido commented Dec 27, 2024

Hey @b4s36t4 let's have a chat on Superset Slack

@LevisNgigi LevisNgigi linked a pull request Dec 27, 2024 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
#bug Bug report preset:bounty:bug Bugs that have been selected by Preset and have a bounty attached. preset:bounty Issues that have been selected by Preset and have a bounty attached.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(bulk_select): Fix bulk select tagging issues for users LevisNgigi/superset
8 participants
@mistercrunch @yousoph @hughhhh @EddyBess @b4s36t4 @geido @LevisNgigi and others