Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support not generating secrets at all, giving an option to rely on other means to get secrets #45171

Open
2 tasks done
andrii-korotkov-verkada opened this issue Dec 23, 2024 · 2 comments · May be fixed by #45248
Open
2 tasks done
Labels
area:secrets kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet

Comments

@andrii-korotkov-verkada

Description

Allow to skip secrets creation completely, providing a way to use other means to get the secret data (e.g. AWS secrets manager with init in airflowLocalSettings).

Use case/motivation

When using ArgoCD to manage manifests, committing secrets to the repo is undesirable due to security reasons. Also, if using AWS secrets manager to store secrets, the Kubernetes secrets won't be necessary.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@andrii-korotkov-verkada
Copy link
Author

A related discussion about storing encrypted secret values #45190.

@andrii-korotkov-verkada
Copy link
Author

This can be mostly done by setting some placeholder values for secret names, as well as not setting env variables on pod templates. A couple of things that can't be configured this way are pgbouncer mounts and pgbouncer stats env variable for connection. I'll add a PR to address that.

andrii-korotkov-verkada added a commit to andrii-korotkov-verkada/airflow that referenced this issue Dec 27, 2024
closes: apache#45171

Allow to disable adding default secret mounts for pgbouncer configs as well as metrics exported database url env variable. This can be useful for cases, where the value is retrieved other way, e.g. secrets provider class.

Signed-off-by: Andrii Korotkov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:secrets kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant