You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But the angulartics documentation says that setUserProperties first argument is a properties object:
$analytics.setUserProperties(properties)
This makes it difficult to use the segment plugin with other angulartics plugins since it changes the signature.
My suggestion would be to change the signature to no longer accept userId and start with the traits. Then implement the registerSetUsername method to just pass userId to the segment identify call.
Unfortunately this appears to be breaking change, so not sure how you'd want to handle the versioning.
The text was updated successfully, but these errors were encountered:
The current code has this:
But the angulartics documentation says that setUserProperties first argument is a properties object:
This makes it difficult to use the segment plugin with other angulartics plugins since it changes the signature.
My suggestion would be to change the signature to no longer accept userId and start with the traits. Then implement the registerSetUsername method to just pass userId to the segment identify call.
Unfortunately this appears to be breaking change, so not sure how you'd want to handle the versioning.
The text was updated successfully, but these errors were encountered: