-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjust frequency-graph max to reflect change in psutil reporting #180
Comments
my units might be wrong... it may be that 5.9 reports instantaneous frequency in GHz (and max frequency in MHz). |
Hah, missed this ticket here. I reported the issue in psutil: giampaolo/psutil#2049 It appears that giampaolo/psutil#1852 implemented caching and might have changed the behavior by that. |
Nice. looks like the change made in |
Thank you for openning the issue. For now you can try manually installing the latest version of psutil |
This issue, which is actually caused by 'psutil' == 5.9.0 can be solved by downgrade pstuil v5.8.0. However, I'm not very sure about the root of this problem currently. |
Installing psutil 5.9.1 solved the issue too. |
I modified the source code to multiply by 1000. I came to report the issue and found this. The fix is indeed to update your version of psutil, not a problem with s-tui. pip install --upgrade psutil That was the fix |
Is your feature request related to a problem? Please describe.
Looks like
psutil v5.8.0
(used ins-tui v1.0.0
) reported max frequency and instantaneous frequency in KHz, whilepsutil v5.9.0
(latest version, and installed with current implementation ofs-tui
) reports max frequency in KHz but instantaneous frequency in MHz. Hence, the scale of the frequency bar graph is such that frequency bars are too small to be seen.Describe the solution you'd like
Modify function in
s_tui.sources.freq_source.py
as follows:def get_top(self):
logging.debug("Returning top %s", self.top_freq)
# top frequency is in KHz, live frequency is in MHz, looks like. Need to divide top by 1000 so the
# graph is scaled correctly
return self.top_freq / 1000
Additional context
May need some check of what version
psutil
is running and adjust this function accordingly...The text was updated successfully, but these errors were encountered: