Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum Python version for oocmap #15

Open
soldni opened this issue Aug 12, 2022 · 0 comments
Open

Set minimum Python version for oocmap #15

soldni opened this issue Aug 12, 2022 · 0 comments

Comments

@soldni
Copy link
Member

soldni commented Aug 12, 2022

Clang fails compilation on my M1 Mac with Python <= 3.8:

      clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /Users/lucas/miniforge3/envs/oocmap/include -arch arm64 -fPIC -O2 -isystem /Users/lucas/miniforge3/envs/oocmap/include -arch arm64 -I/opt/homebrew/opt/mysql-client/include -I/Users/lucas/miniforge3/envs/oocmap/include/python3.8 -c lazydict.cpp -o build/temp.macosx-11.0-arm64-cpython-38/lazydict.o
      lazydict.cpp:281:12: error: use of undeclared identifier 'PyObject_CallOneArg'; did you mean 'PyObject_CallObject'?
          return PyObject_CallOneArg(reinterpret_cast<PyObject*>(&OOCLazyDictItemsType), pySelf);
                 ^~~~~~~~~~~~~~~~~~~
                 PyObject_CallObject
      /Users/lucas/miniforge3/envs/oocmap/include/python3.8/abstract.h:163:24: note: 'PyObject_CallObject' declared here
      PyAPI_FUNC(PyObject *) PyObject_CallObject(PyObject *callable,
                             ^
      lazydict.cpp:285:12: error: use of undeclared identifier 'PyObject_CallOneArg'; did you mean 'PyObject_CallObject'?
          return PyObject_CallOneArg(reinterpret_cast<PyObject*>(&OOCLazyDictKeysType), pySelf);
                 ^~~~~~~~~~~~~~~~~~~
                 PyObject_CallObject
      /Users/lucas/miniforge3/envs/oocmap/include/python3.8/abstract.h:163:24: note: 'PyObject_CallObject' declared here
      PyAPI_FUNC(PyObject *) PyObject_CallObject(PyObject *callable,
                             ^
      lazydict.cpp:289:12: error: use of undeclared identifier 'PyObject_CallOneArg'; did you mean 'PyObject_CallObject'?
          return PyObject_CallOneArg(reinterpret_cast<PyObject*>(&OOCLazyDictValuesType), pySelf);
                 ^~~~~~~~~~~~~~~~~~~
                 PyObject_CallObject
      /Users/lucas/miniforge3/envs/oocmap/include/python3.8/abstract.h:163:24: note: 'PyObject_CallObject' declared here
      PyAPI_FUNC(PyObject *) PyObject_CallObject(PyObject *callable,
                             ^
      lazydict.cpp:293:12: error: use of undeclared identifier 'PyObject_CallOneArg'; did you mean 'PyObject_CallObject'?
          return PyObject_CallOneArg(reinterpret_cast<PyObject*>(&OOCLazyDictKeysIterType), pySelf);
                 ^~~~~~~~~~~~~~~~~~~
                 PyObject_CallObject
      /Users/lucas/miniforge3/envs/oocmap/include/python3.8/abstract.h:163:24: note: 'PyObject_CallObject' declared here
      PyAPI_FUNC(PyObject *) PyObject_CallObject(PyObject *callable,
                             ^
      lazydict.cpp:759:33: error: use of undeclared identifier 'PyObject_CallOneArg'; did you mean 'PyObject_CallObject'?
          PyObject* const itemsIter = PyObject_CallOneArg(reinterpret_cast<PyObject*>(&OOCLazyDictItemsIterType), dictObject);
                                      ^~~~~~~~~~~~~~~~~~~
                                      PyObject_CallObject
      /Users/lucas/miniforge3/envs/oocmap/include/python3.8/abstract.h:163:24: note: 'PyObject_CallObject' declared here
      PyAPI_FUNC(PyObject *) PyObject_CallObject(PyObject *callable,
                             ^
      lazydict.cpp:940:33: error: use of undeclared identifier 'PyObject_CallOneArg'; did you mean 'PyObject_CallObject'?
          PyObject* const itemsIter = PyObject_CallOneArg(reinterpret_cast<PyObject*>(&OOCLazyDictItemsIterType), dictObject);
                                      ^~~~~~~~~~~~~~~~~~~
                                      PyObject_CallObject
      /Users/lucas/miniforge3/envs/oocmap/include/python3.8/abstract.h:163:24: note: 'PyObject_CallObject' declared here
      PyAPI_FUNC(PyObject *) PyObject_CallObject(PyObject *callable,
                             ^
      6 errors generated.
      error: command '/usr/bin/clang' failed with exit code 1
      [end of output]

OOCMap builds and installs fine on Python 3.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant