Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] estimators failing check_regressor_against_expected_results #2458

Open
2 tasks
TonyBagnall opened this issue Dec 16, 2024 · 2 comments
Open
2 tasks

[ENH] estimators failing check_regressor_against_expected_results #2458

TonyBagnall opened this issue Dec 16, 2024 · 2 comments
Labels
enhancement New feature, improvement request or other non-bug code enhancement

Comments

@TonyBagnall
Copy link
Contributor

Describe the feature or idea you want to propose

no idea on these

  • "RDSTRegressor"
  • "RISTRegressor"

Describe your proposed solution

fix or create issue

Describe alternatives you've considered, if relevant

No response

Additional context

No response

@TonyBagnall TonyBagnall added the enhancement New feature, improvement request or other non-bug code enhancement label Dec 16, 2024
@ricor07
Copy link

ricor07 commented Dec 28, 2024

Hello, I'd like to join the project by working on this issue.

@baraline
Copy link
Member

baraline commented Dec 28, 2024

Hi @ricor07, just a heads-up, this issue is a bit tricky, so if you are new to python/numba/git CI, this might not be the easiest place to start with.

The problem we're facing is that these two estimators (RDST and RIST) are failing a test (check_regressor_against_expected_results, see this file and this one to reproduce the results) on some of the platforms we are testing on (Ubuntu/Windows/MacOS).

The problem is that the expected results can differ (despite fixing a random seed) from platform to platform. The goal of the issue is to understand and fix this, but we didn't have much success on that for now. You can go in the test_config file to make these test run on the CI, otherwise there are excluded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, improvement request or other non-bug code enhancement
Projects
None yet
Development

No branches or pull requests

3 participants