Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: text is not vertically centered for "Small" sized Buttons #4851

Open
1 task done
Rajdeepc opened this issue Oct 23, 2024 · 2 comments
Open
1 task done

[Bug]: text is not vertically centered for "Small" sized Buttons #4851

Rajdeepc opened this issue Oct 23, 2024 · 2 comments
Labels
bug Something isn't working firefox Use this label on pull requests to perf benchmark in Firefox jira ticket created Visual Bug

Comments

@Rajdeepc
Copy link
Contributor

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

Button

Expected behavior

text is should be vertically centered for "Small" sized Buttons

Actual behavior

text is not vertically centered for "Small" sized Buttons on Firefox and iOS (tested on the iOS 17.5 simulator). Looks fine in Chrome & Safari on MacOS.

Screenshots

Screenshot 2024-10-23 at 11 49 10 AM

What browsers are you seeing the problem in?

Firefox, Chrome, Safari

How can we reproduce this issue?

  1. Go to https://opensource.adobe.com/spectrum-web-components/storybook/index.html?path=/story/button-primary-fill-sizes--s
  2. Check the line height of the text inside the Size S button

Sample code or abstract reproduction which illustrates the problem

No response

Severity

SEV 4

Logs taken while reproducing problem

No response

@Rajdeepc Rajdeepc added bug Something isn't working triage An issue needing triage needs jira ticket labels Oct 23, 2024
@najikahalsema najikahalsema added Visual Bug firefox Use this label on pull requests to perf benchmark in Firefox iOS bug reported in iOS devices jira ticket created and removed triage An issue needing triage iOS bug reported in iOS devices needs jira ticket labels Oct 23, 2024
@Rajdeepc
Copy link
Contributor Author

@pfulton Can you please help us triage this. I see this in CSS size S buttons

@rise-erpelding
Copy link

Hi @Rajdeepc! It looks like we tried to fix this awhile back: adobe/spectrum-css#2145

Ultimately since the issue is specific to MacOS Firefox (and not Windows), it's tricky to target a fix that won't affect other browsers.

This relates to a longstanding bug in Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=480196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working firefox Use this label on pull requests to perf benchmark in Firefox jira ticket created Visual Bug
Projects
None yet
Development

No branches or pull requests

3 participants