Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor nodeLibs/default.nix to be more callPackage friendly #117

Open
ixmatus opened this issue Feb 23, 2018 · 0 comments
Open

Refactor nodeLibs/default.nix to be more callPackage friendly #117

ixmatus opened this issue Feb 23, 2018 · 0 comments
Assignees
Labels

Comments

@ixmatus
Copy link
Collaborator

ixmatus commented Feb 23, 2018

The nodeLibs/default.nix can be refactored such that it can be callPackage'ed and the generated nodePackage set be the direct result of doing so; meaning, we can remove the makeOverridable on the generatePackages function because callPackage will do that for us.

This also entails moving the arguments for overrides and other things out to the top intake arguments that callPackage would fill-in so that when a user uses the .override { ... } on the result of callPackage'ing nodeLibs/default.nix they can provide the overrides = ... attribute.

This would remove the indirection that currently exists. It is also a backwards breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant