Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm command does not exist #1165

Closed
misogihagi opened this issue Nov 28, 2024 · 5 comments
Closed

pnpm command does not exist #1165

misogihagi opened this issue Nov 28, 2024 · 5 comments
Labels
feature request New feature or request to improve the current logic

Comments

@misogihagi
Copy link

Description:
I'm using pnpm in my project.
setup-node does not work.

Run actions/setup-node@v4
Node version file is not JSON file
Resolved .node-version as 21.6.2
Attempting to download 21.6.2...
Not found in manifest. Falling back to download directly from Node
Acquiring 21.6.2 - x64 from https://nodejs.org/dist/v21.6.2/node-v21.6.2-linux-x64.tar.gz
Extracting ...
/usr/bin/tar xz --strip 1 --warning=no-unknown-keyword --overwrite -C /home/runner/work/_temp/c6e9e174-8852-4a50-b423-4526257ae884 -f /home/runner/work/_temp/e3b0661a-cfe3-408e-b1c4-7e2616add902
Adding to the cache ...
Done
Environment details
/opt/hostedtoolcache/node/21.6.2/x64/bin/npm config get cache
/home/runner/.npm
Error: Dependencies lock file is not found in /home/runner/work/lighthouse-ci-datadog-action/lighthouse-ci-datadog-action. Supported file patterns: package-lock.json,npm-shrinkwrap.json,yarn.lock

Justification:
yarn is available. why don't we use also pnpm?

@misogihagi misogihagi added feature request New feature or request to improve the current logic needs triage labels Nov 28, 2024
@priyagupta108
Copy link
Contributor

Hi, @misogihagi 👋, Thank you for the feature request, we will investigate it and get back to you as soon as we have updates.

@tatethurston
Copy link

pnpm is already supported. per the project readme, specify cache.

@misogihagi
Copy link
Author

My apologies.
I said something misleading.
Here is my code.

      - uses: actions/checkout@v4
      - uses: actions/setup-node@v4
        with:
          cache: pnpm
      - run: pnpm install

It doesn't work because pnpm doesn't exist. yarn exists!

Similar to the #530 .

Why does yarn exist in default?

@o-l-a-v
Copy link

o-l-a-v commented Dec 28, 2024

Yarn is in the GitHub runner images, while pnpm is not:

You could enable corepack or install pnpm with npm or Yarn. Or use this action:

@misogihagi
Copy link
Author

Thanks!
It seems to depend on the base image of the github action in question
I'll close it here.

@misogihagi misogihagi changed the title pnpm Support pnpm command does not exist Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

4 participants