Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify DI to inject service interface instead of implementation #53

Open
BastienPerdriau opened this issue Aug 18, 2023 · 0 comments
Open

Modify DI to inject service interface instead of implementation #53

BastienPerdriau opened this issue Aug 18, 2023 · 0 comments

Comments

@BastienPerdriau
Copy link

Hello,

I'm wondering if it could be possible to inject the ILogAnalyticsClient interface instead of LogAnalyticsClient class ?

By replacing

services.AddHttpClient<LogAnalyticsClient>();

by

services.AddHttpClient<ILogAnalyticsClient, LogAnalyticsClient>();

I think it would make a breaking change when getting LogAnalyticsClient in services constructor but it would be more easier to mock services in tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BastienPerdriau