You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'd like to construct an instance of Extensions.CredentialProperties.CredentialPropertiesOutput but the constructor is not public. Can you please make the constructor public?
Details
The Extensions.CredentialProperties.CredentialPropertiesOutput is not public which means that users can only create an instance of this object through reflection (e.g. using Jackson's ObjectMapper). This means that the only way users can use CredentialPropertiesOutput is through reflection or by deserializing JSON. This limits how the data can be sent from the client to the server.
A specific problem I'm running into is that I would like to have an interface that prevents downstream libraries from depending directly on java-webauthn-server. By doing this we can provide additional implementations of the same interface with different libraries without breaking downstream users.
However, for this to work I need to be able to create a Extensions.CredentialProperties.CredentialPropertiesOutput directly from our Object rather than from JSON.
Please make the Extensions.CredentialProperties.CredentialPropertiesOutput constructor public to allow more flexible usage of this extension.
The text was updated successfully, but these errors were encountered:
Hi! Seems fair - especially since ClientAssertionExtensionOutputs etc. have corresponding public builders, which seems a bit moot if you can't actually construct the constituent values. This will be included in the next release.
Summary
I'd like to construct an instance of
Extensions.CredentialProperties.CredentialPropertiesOutput
but the constructor is not public. Can you please make the constructor public?Details
The
Extensions.CredentialProperties.CredentialPropertiesOutput
is not public which means that users can only create an instance of this object through reflection (e.g. using Jackson's ObjectMapper). This means that the only way users can useCredentialPropertiesOutput
is through reflection or by deserializing JSON. This limits how the data can be sent from the client to the server.A specific problem I'm running into is that I would like to have an interface that prevents downstream libraries from depending directly on java-webauthn-server. By doing this we can provide additional implementations of the same interface with different libraries without breaking downstream users.
However, for this to work I need to be able to create a
Extensions.CredentialProperties.CredentialPropertiesOutput
directly from our Object rather than from JSON.Please make the
Extensions.CredentialProperties.CredentialPropertiesOutput
constructor public to allow more flexible usage of this extension.The text was updated successfully, but these errors were encountered: