Commanders Linked in 4.5.3

[FreddieWitherden]

Describe the bug
In the attached campaign save game from 4.5.3 there are two commanders. However, they appear to be linked wherein adding units to one adds it to another as if they're both internally referencing the same structure. (For example sending one to recycle sends the other, too.)

Additional context
Alpha 8 Base.zip

[KJeff01]

Your save seems to have been generated from 4.4.2 according to the gameinfo.json file. This issue should have been fixed with these commits/PRs since 4.5.0-beta1.

warzone2100/ChangeLog

Line 147 in 04c3706

* Fix: Prevent issues with Commanders losing groups, or Commander groups being "tied" together, after offworld transition or saveloading (commit:ba37c6ecc04a1da3c348d6a0408faab5838df9d4, commit:28f50a76c094dde37e79ce5b0efa79873c1a8b9f, #3596, #3728)

Are you sure you are seeing this on a 4.5 series release?

[FreddieWitherden]

Apologies for my belated response. The save game was created with 4.4.2. Upon encountering the issue I upgraded to 4.5.3. Is the save file itself bad?

[KJeff01]

When I loaded it on 4.5.3/master I wasn't seeing issues. I personally worked on the campaign pretty hard since August of last year for 4.5.x doing all kinds of quality of life fixes and updates, and played the campaign a lot (maybe burnt myself out a little). In all the runs that took place after those Commander related commits I didn't see this. That said, if by some chance it's actually still happening from an older save on 4.5.3, then recycling the commanders and rebuilding them will reset everything for sure. It should auto-fix upon loading it from a 4.5 release however. So, the save itself shouldn't be bad.