Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Youtube clips loading incorrectly when using YoutubeAdblock plugin #3063

Open
2 tasks done
NorthLake opened this issue Dec 4, 2024 · 5 comments
Open
2 tasks done
Labels
bug Something isn't working

Comments

@NorthLake
Copy link

Discord Account

northlake

What happens when the bug or crash occurs?

When clicking play on an embed of a Youtube clip the plugin will block the ad, but after that the entire video will be loaded instead of just the clip.
Note: the clip I've tried it with, is this one.

What is the expected behaviour?

The ad is blocked and the clip is played

How do you recreate this bug or crash?

  1. Send a link to a Youtube clip
  2. Click play on the embed

Errors

Unsure if these are related to the bug, but they are logged as the clip/video is loaded

web.5136eb1709360a4c0ae8.js:12 Unrecognized Content-Security-Policy directive 'prefetch-src'.
e @ web.5136eb1709360a4c0ae8.js:12
e @ web.5136eb1709360a4c0ae8.js:12
e @ web.5136eb1709360a4c0ae8.js:12
e @ web.5136eb1709360a4c0ae8.js:12
sQ @ web.5136eb1709360a4c0ae8.js:12
sq @ web.5136eb1709360a4c0ae8.js:12
sz @ web.5136eb1709360a4c0ae8.js:12
sq @ web.5136eb1709360a4c0ae8.js:12
sz @ web.5136eb1709360a4c0ae8.js:12
[sq and sz alternating a LOT of times]
sz @ web.5136eb1709360a4c0ae8.js:12
sq @ web.5136eb1709360a4c0ae8.js:12
sz @ web.5136eb1709360a4c0ae8.js:12
sq @ web.5136eb1709360a4c0ae8.js:12
cast_sender.js:87 Uncaught SecurityError: Failed to construct 'PresentationRequest': The document is sandboxed and lacks the 'allow-presentation' flag.
    at W.initialize (cast_sender.js:87:87)
    at chrome.cast.initialize (cast_sender.js:99:137)
    at g.k.init (remote.js:578:77)
    at zxb (remote.js:249:40)
    at pxb (remote.js:255:9)
    at d.disableCastApi.window.chrome.chrome.cast.chrome.cast.isAvailable.window.__onGCastApiAvailable (remote.js:243:402)
    at chrome.cast.da (cast_sender.js:101:297)
    at cast_sender.js:101:349
    at cast_sender.js:101:471

Request Agreement

  • I am using Discord Stable or tried on Stable and this bug happens there as well
  • I have read the requirements for opening an issue above
@NorthLake NorthLake added the bug Something isn't working label Dec 4, 2024
@TheOnlyWayUp
Copy link

Can reproduce

@ioj4
Copy link
Contributor

ioj4 commented Dec 6, 2024

As far as I can tell this is just normal Discord behavior. There is probably no way to embed Youtube clips yet. If you look into the iframe, it's an url of the video embed (https://www.youtube.com/embed/skOHlrX_U5g), not the clip.

@ioj4
Copy link
Contributor

ioj4 commented Dec 6, 2024

@NorthLake
Copy link
Author

As far as I can tell this is just normal Discord behavior.

I seriously remember watching a YouTube clip while not having the plugin active. Maybe it's déjà vu? Either way, clicking an embed without the plugin right now plays an ad, and then loads the entire video. Clicking play on the embed on the Android app (vanilla) does load the clip correctly, though. Maybe the fact that an ad plays is what screws it up? I'm not sure.
And even if Discord itself doesn't load clips correctly. Maybe it's something the plugin can fix?

@lolsuffocate
Copy link

This is just a stock Discord issue, it did work before. Timestamped links don't go to the timestamp in the embed anymore either

Repository owner deleted a comment Jan 3, 2025
Repository owner deleted a comment Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants