Fix convex function ignoring given properties #2765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kareemjeiroudi
changed the title
4 tasks
smallsaucepan
requested changes
Dec 14, 2024
There was a problem hiding this comment.
Thanks for this @kareemjeiroudi. Just a request for a minor change to test.ts and we should be good to go!
| @@ -32,3 +33,17 @@ test("turf-convex -- empty", (t) => { | |||
| t.deepEqual(convex(featureCollection([])), null, "corner case: null hull"); | |||
| t.end(); | |||
| }); | |||
|
|
|||
| test("turf-convex -- properties are returned", (t) => { | |||
There was a problem hiding this comment.
Could you please make the test name more descriptive? Maybe "properties are transferred to result polygon" instead?
There was a problem hiding this comment.
Sure. Thanks for the feedback. I'll get back to this as soon as back from holidays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Using the
convexfunction to combine a feature collection returns a newly constructed polygon with missing properties. This crucial if the caller of function attempts to pass additional properties the end polygon.PR includes a test to test this scenario and improved typing
Resolve #2762
This change fixes a bug where the convex function ignores given properties. I came across this problem, as I was working on a project for one of our clients