Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict crash reporting to amaze package name #2641

Open
VishalNehra opened this issue Jun 18, 2021 · 1 comment · May be fixed by #2649
Open

Restrict crash reporting to amaze package name #2641

VishalNehra opened this issue Jun 18, 2021 · 1 comment · May be fixed by #2649
Labels
Issue-Bug Related unexpected behavior or something worth investigating. Issue-Severe (high) Showstopper issues that require immediate attention
Milestone
v4.0

Comments

@VishalNehra
Copy link
Member

Due to limited resources quota on cloud platform and email service, better check package name before allowing user to send crash reports.
Also show a message to user stating that their version is not official within the app itself instead of replying to their email.
@VishalNehra VishalNehra added the Issue-Discussion Deprecated: use discussions tab. label Jun 18, 2021
@VishalNehra VishalNehra added this to the v3.7 milestone Jun 18, 2021
@EmmanuelMess
Copy link
Member

Due to limited resources quota on cloud platform and email service, better check package name before allowing user to send crash reports.

In favor.

@EmmanuelMess EmmanuelMess added Issue-Bug Related unexpected behavior or something worth investigating. Issue-Severe (high) Showstopper issues that require immediate attention and removed Issue-Discussion Deprecated: use discussions tab. labels Jun 19, 2021
@VishnuSanal VishnuSanal modified the milestones: v3.7, v3.6.2 Jun 20, 2021
@VishnuSanal VishnuSanal self-assigned this Jun 20, 2021
TranceLove added a commit that referenced this issue Jun 20, 2021
@TranceLove
Verify package name before initializing ACRA and ErrorActivity
b290ff7 
Fixes #2641.

Implementation is a bit primitive, and given the source code is publicly available, we can only slow down, but not prohibiting others from pirating without a decent code signing mechanism that will work across github, f-droid and derivatives, and google play.
TranceLove added a commit that referenced this issue Jun 20, 2021
@TranceLove
Verify package name before initializing ACRA and ErrorActivity
6ad477e 
Fixes #2641.

Implementation is a bit primitive, and given the source code is publicly available, we can only slow down, but not prohibiting others from pirating without a decent code signing mechanism that will work across github, f-droid and derivatives, and google play.
TranceLove added a commit that referenced this issue Jun 20, 2021
@TranceLove
Verify package name before initializing ACRA and ErrorActivity
058fc06 
Fixes #2641.

Implementation is a bit primitive, and given the source code is publicly available, we can only slow down, but not prohibiting others from pirating without a decent code signing mechanism that will work across github, f-droid and derivatives, and google play.
@TranceLove TranceLove linked a pull request Jun 20, 2021 that will close this issue
Draft
3 tasks
@VishnuSanal VishnuSanal removed their assignment Jun 20, 2021
@VishalNehra VishalNehra modified the milestones: v3.6.2, v3.7 Sep 19, 2021
@VishalNehra VishalNehra modified the milestones: v3.7, v4.0 Apr 24, 2022
@VishalNehra VishalNehra modified the milestones: v3.9, v4.0 Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Bug Related unexpected behavior or something worth investigating. Issue-Severe (high) Showstopper issues that require immediate attention
Projects
None yet
Milestone
v4.0
Development

Successfully merging a pull request may close this issue.

Verify package name before initializing ACRA and ErrorActivity TeamAmaze/AmazeFileManager
3 participants
@VishalNehra @EmmanuelMess @VishnuSanal