Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor EditorUIService to use LSP showMessage and showMessageRequest #2179

Open
2 tasks done
JustinGrote opened this issue Sep 16, 2024 · 0 comments
Open
2 tasks done
Labels
Issue-Enhancement A feature request (enhancement). Needs: Triage Maintainer attention needed!

Comments

@JustinGrote
Copy link
Collaborator

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues to ensure it has not already been reported.

Summary

EditorUIService currently uses custom messages to handle prompts. They should use the LSP spec for this instead so it doesn't have to be handled special in the client.

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#window_showMessageRequest

Proposed Design

Replace existing messaging with LSP but keep methods the same if possible to avoid breaking.

@JustinGrote JustinGrote added Issue-Enhancement A feature request (enhancement). Needs: Triage Maintainer attention needed! labels Sep 16, 2024
@JustinGrote JustinGrote transferred this issue from PowerShell/vscode-powershell Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Enhancement A feature request (enhancement). Needs: Triage Maintainer attention needed!
Projects
None yet
Development

No branches or pull requests

1 participant