You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It turns out that the URIs and paths we're receiving "over the wire" (in the raw LSP requests themselves) are mostly cased correctly, with the exception of driver letters being lower case. Because of this, when PowerShell/PowerShell#20057 was temporarily fixed by making PowerShell's debugger's _pendingBreakpoints collection case-sensitive, it broke the extension's debugger PowerShell/vscode-powershell#4668.
We need to figure out why those drive letters are coming over lower-case, as the rest of the Windows ecosystem doesn't expect drive letters to be lowercase. Worst case scenario is that we fix the casing as we handle the request, but I'd like to see where the issue originates (thinking perhaps in the LSP client library...) and try to fix it there. Though technically c:/ is valid, and it's mostly PowerShell that's caring about it not being C:/.
The text was updated successfully, but these errors were encountered:
In summary, this isn't something PSES or vscode-powershell is doing wrong, it's a consequence of receiving URIs from VS Code where they enforce the drive-letter being lowercase, and this does not match up with PowerShell's own expectation that the drive-letter is upper-case. So @fflaten I think that when PowerShell/PowerShell#20057 is fixed to support distinguishing files in the PowerShell debugger on case-sensitive filesystems, the simplest answer is to fix it only when on a case-sensitive filesystem.
I don't like the idea of trying to handle this in PSES be re-upper-casing drive letters in each and every handler; we're going to miss something and things will suspiciously break again.
This odd behavior was first noticed in a test:
PowerShellEditorServices/test/PowerShellEditorServices.Test/Debugging/DebugServiceTests.cs
Lines 140 to 141 in bfe334d
It turns out that the URIs and paths we're receiving "over the wire" (in the raw LSP requests themselves) are mostly cased correctly, with the exception of driver letters being lower case. Because of this, when PowerShell/PowerShell#20057 was temporarily fixed by making PowerShell's debugger's
_pendingBreakpoints
collection case-sensitive, it broke the extension's debugger PowerShell/vscode-powershell#4668.We need to figure out why those drive letters are coming over lower-case, as the rest of the Windows ecosystem doesn't expect drive letters to be lowercase. Worst case scenario is that we fix the casing as we handle the request, but I'd like to see where the issue originates (thinking perhaps in the LSP client library...) and try to fix it there. Though technically
c:/
is valid, and it's mostly PowerShell that's caring about it not beingC:/
.The text was updated successfully, but these errors were encountered: