Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for correct format args count #10

Open
elegaanz opened this issue May 16, 2019 · 2 comments
Open

Check for correct format args count #10

elegaanz opened this issue May 16, 2019 · 2 comments

Comments

@elegaanz
Copy link
Member

  • Check that the number of format arguments matches the one in the source string.
  • Check that the same arguments are used in source strings and translations in compile_i18n?
@trinity-1686a
Copy link

Thinking about it, I wonder if compile_i18n and maybe other macros shouldn't actually be functions called from build.rs. They are not actually generating any code in the end executable and are just here for there side effects

@elegaanz
Copy link
Member Author

The problem is that they need to be "called" after the .pot have been updated by the various i18n!/t! calls, but build.rs can only run before the crate itself is compiled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants