Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Official release ships with CLI version/UI is also usable CLI only. #34

Open
NullPlane opened this issue Aug 20, 2022 · 11 comments
Labels
enhancement New feature or request

Comments

@NullPlane
Copy link

That would make it easy to ship it precast configurated with skins and create one-click installation scripts

@PhantomGamers PhantomGamers added the enhancement New feature or request label Aug 20, 2022
@PhantomGamers
Copy link
Owner

No ETA but I will try to do this in the next release. I formatted the code in such a way as to make cli usage easier to implement as I had always planned on doing it but I keep putting it off 😅

@Oman395
Copy link

Oman395 commented Mar 17, 2023

Just gonna throw a +1 on this, SFP is currently required to install catppuccin/steam, and is the only major issue we have to deal with to get an automated install script working-- if you can't work on this right now, it would be great if you could point me where I can download the files manually, so I can write a script to do it that way.

@PhantomGamers
Copy link
Owner

@Oman395 What files are you referring to?

@Oman395
Copy link

Oman395 commented Mar 17, 2023

The patched CSS files (unless it patches them in a different way, I'm not sure how SFP works specifically), I just need to replicate the basic patching functionality in something that doesn't require user intervention

@PhantomGamers
Copy link
Owner

The app does not download anything, it patches the css itself.

@Oman395
Copy link

Oman395 commented Mar 17, 2023

Ah-- what patches does it apply? Does it just insert imports to files that can be specified by themes or something?

@Oman395
Copy link

Oman395 commented Mar 17, 2023

Just did some testing, looks like it patches steamui/css/*.css and clientui/css/friends.css, anything else I'm missing or is that it?

@PhantomGamers
Copy link
Owner

For the library patching it replaces all css files in steamui/css with files that only contain @import url(\"https://steamloopback.host/{dirName}{originalFile.Name}\");\n@import url(\"https://steamloopback.host/{customFile.Name}\");\n" and padding to make them match the original file sizes.

See https://github.com/PhantomGamers/SFP/blob/main/SFP/Models/LocalFile.cs for more information.

I also think there is some confusion on your theme page, as it appears your theme does not actually do anything that would require SFP. SFP just enables loading library skins from a libraryroot.custom.css file in steamui.

@Oman395
Copy link

Oman395 commented Mar 17, 2023

It's based on steam-library for library theming, which uses the webkit.css for linux and says that SFP is a requirement-- I'll have to test without SFP, but if we don't need the step at all, that would be awesome. Thanks for taking the time to answer my questions!

@PhantomGamers
Copy link
Owner

SFP is a requirement on windows when libraryroot.custom.css is used instead of webkit.css.

It would also be a requirement on linux if a library skin author opted to use the libraryroot.custom.css approach.

The benefit of such being that auto updates are possible as with libraryroot.custom.css you can use @import tags whereas in the webkit.css file you cannot.

@Oman395
Copy link

Oman395 commented Mar 17, 2023

Yup, makes sense. Just tested without patches and it works exactly the same. Thanks again for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants