Suggested improvement to the "Group by annotation color, customized label" cheat sheet

[FeralFlora]

I suggest changing the for-loop that outputs the headings and associated annotations from this:

for (const color in byColor) { -%>

## <%= label[color] ?? color %>
  <%_ for (const annot of byColor[color]) { %>

<%~ include("annotation", annot) %>
  <%_ } %>
<% } %>

to this:

for (const color in label) { -%>

<% if (color in byColor) { %>
### <%= label[color] ?? color %>
  <%_ for (const annot of byColor[color]) { %>

<%~ include("annotation", annot) %>
    <%_ } %>
  <%_ } %>
<% } %>

I loop over the colors in label rather than byColor, and add a conditional so that colors in byColor are output if they are present in label. This way, the color group headings will be output in the same order as set in label. This ensures that literature notes are consistently formatted. Without this, the groups will be in the sequence of colors in the source document, so it will not be consistent.

There might need to be some else statement to catch colors that are not in label.

[FeralFlora]

I have tested this, and it works.

[aidenlx]

Here is the updated template:

<% const byColor = Object.groupBy(it, (annot) => annot.colorName);
const label = {
  "red": "Important",
  "orange": "Question",
  "yellow": "Summary",
  "gray": "Comment",
  "green": "Answer",
  "cyan": "Task",
  "blue": "Fact",
  "navy": "Definition",
  "purple": "Quote",
  "brown": "Source",
  "magenta": "To Do",
};
// Merge colors with customized label with unexpected colors, if any
// Keep the order of the colors from the original color-label map
const colorSet = new Set([...Object.keys(label), ...Object.keys(byColor)]);
for (const color of colorSet) { 
if (!(color in byColor)) continue -%>

### <%= label[color] ?? color %>
  <%_ for (const annot of byColor[color]) { %>

<%~ include("annotation", annot) %>
  <%_ } %>
<% } %>