Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Bringing back the global toggles for Widescreen and No-Interlace Patches, but better #12113

Closed
CookiePLMonster opened this issue Dec 23, 2024 · 5 comments · Fixed by #12117
Closed

[Feature Request]: Bringing back the global toggles for Widescreen and No-Interlace Patches, but better #12113

CookiePLMonster opened this issue Dec 23, 2024 · 5 comments · Fixed by #12117
Labels
Enhancement / Feature Request FR: Awaiting Consideration The feature request is awaiting a team members consideration. Question / Discussion

Comments

@CookiePLMonster
Copy link
Contributor

CookiePLMonster commented Dec 23, 2024 •
edited
Loading

Description

#12078 removed global Widescreen and No-Interlace Patch toggles citing support maintenance and UX clarity as reasons. This led to some confusion about the current state of these patches, and now forces users to audit per-game settings for every single game they own.

The main issues with the global toggles were:

  • Users enabled them once and forgot about them, which led to support issues with people swearing they have no patches enabled, when they had.
  • The Patches screen had a very confusing UI for those fixes - despite these toggles being globally enabled, these patches were unchecked in the list, gaslighting the user into believing that:
    • They were disabled (they were not)
    • They had a choice of toggling them on/off per game (they did not)
      Image

While those are legitimate issues, they do not outweigh the downsides of forcing users to do the additional legwork. I propose the following:

  1. Bring back the toggles exactly how they were.
  2. Keep those toggles global only, do not show them in menus per-game.
  3. Adjust the Patches screen with the following changes:
    1. Make Widescreen/No-Interlace patches support tri-state checkboxes.
    2. Add an additional text notifying the user about the global state of those patches.
    3. Make the tri-state checkbox work as logically expected:
      • Undefined (box) - use the global option
      • Unchecked - disable the patch regardless of the global option
      • Checked - enable the patch regardless of the global option

Here's how the revised screen could look:
Image

Reason

Better user experience. No need to enable patches per-game over and over. Global toggles like this also exist in other emulators (e.g. Flycast).
@CookiePLMonster CookiePLMonster added Enhancement / Feature Request FR: Awaiting Consideration The feature request is awaiting a team members consideration. labels Dec 23, 2024
@CookiePLMonster CookiePLMonster mentioned this issue Dec 23, 2024
Merged
@crashGG
Copy link
Contributor

crashGG commented Dec 23, 2024

I agree with restoring the global SW and No-interlacing switch and improving the display to a smarter approach.

When a function needs to be used repeatedly, it is logically necessary to use a global switch.

I can also understand why maintainers simply cut this feature because it is difficult to explain to confused novice users when they encounter this problem.but,Don't throw the baby out with the bathwater,right?

@Mrlinkwii
Copy link
Contributor

I can also understand why maintainers simply cut this feature because it is difficult to explain to confused novice users when they encounter this problem.but,Don't throw the baby out with the bathwater,right?

@crashGG i mean sometimes it may be needed , when people can easily enable & disable patches in 3 clicks

@crashGG
Copy link
Contributor

crashGG commented Dec 23, 2024 •
edited
Loading

@crashGG i mean sometimes it may be needed , when people can easily enable & disable patches in 3 clicks

I prefer to turn on the global switch by default to enjoy the improvements brought by the patch. When a (very few) patch is broken, click 3 times to turn off the patch. Instead of the current situation where each game needs to click 3 times to turn on the improvement, and when a patch is broken, it still needs to click 3 times again to turn off.

That's the point of global switches: to eliminate duplication.

In fact, the previous version only needed a simple modification to achieve this function. That is, add the WS and Ni patches to be controlled in per-game setting (Just like in the main settings), and write a note in the "patches" to guide the user to set in "Graphics".like this:

Image

@CookiePLMonster
Copy link
Contributor Author

CookiePLMonster commented Dec 23, 2024 •
edited
Loading

In fact, the previous version only needed a simple modification to achieve this function. That is, add the WS and Ni patches to be controlled in per-game setting (Just like in the main settings), and write a note in the "patches" to guide the user to set in "Graphics".like this:

That's the idea behind my current proposal, yeah. Should combine benefits of both having and not having a global toggle.

I misread your screenshot a bit - per-game toggles for those patches are not a great idea as they may lead to redundancy, and you'd then need to convey in the Patches menu that these two specific patches cannot be toggled from there.

@CookiePLMonster CookiePLMonster mentioned this issue Dec 24, 2024
Merged
@CookiePLMonster
Copy link
Contributor Author

Created #12117 to resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement / Feature Request FR: Awaiting Consideration The feature request is awaiting a team members consideration. Question / Discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Qt/Patches: Bring back the global WS/NI toggle, but make it clearer in the UI CookiePLMonster/pcsx2
3 participants
@CookiePLMonster @Mrlinkwii @crashGG