-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use .NET TimeProvider
and deprecate IClock
#17290
Comments
Thanks for someone mentioning this :) I have thought about using this since .NET 8
While the next release is major, I don't think it's an issue to break this |
Just dropping |
@hishamco I think this was mentioned in the meeting too, that we can keep the |
We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues). This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here. |
Seb do you remember which meeting, I need to check the recording |
It's somewhere in this section: https://youtu.be/Cmu7RLimyoQ?si=Hnxv4IMw3t67b85X&t=2073 |
Is your feature request related to a problem?
From the 17th December meeting: We now have
TimeProvider
in .NET, which is much of the same as ourIClock
(and more, since it also serves other .NET types). We're now thus duplicating .NET functionality.Also see this blog post and this one.
Describe the solution you'd like
Use
TimeProvider
and deprecateIClock
, but keep it in a backward compatible manner.Describe alternatives you've considered
We can just keep our parallel implementation, but it's better to align with the wider .NET ecosystem.
The text was updated successfully, but these errors were encountered: