-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG][FR] Impossible to specify SSL certification #6939
Comments
Hi there, You can install this package, https://pypi.org/project/pip-system-certs/, that will force Python to use the system trust store instead of from the Alternatively, the requests library allows you to define environment variables:
|
@LucaMingarelli, PR #6976 should resolve the issue and provide a way to define these values across all HTTP requests submitted by OpenBB functions, globally. Please try it out, if you have the opportunity. |
Yes, although this may also interfere with settings from other libraries. |
This looks great! I'll try to test it asap |
@LucaMingarelli hi 👋 thanks for this issue |
Hi @piiq I am not fully sure on the more technical details, but internally at work we have two different data sources: one which requires no certificate is specified, the other requiring a specific certificate. Setting the env variable would mean being able to connect to only one of the two sources. For this reason we pass explicitly the path to certificates when instantiating two different sessions. I hope it helps! |
What's the problem of not having this feature?
This feature is essential as its lack prevents using openbb at all when SSL certification is required to connect to the network.
Solution
The library should have some way to specify the path to the SSL certificate. When using requests this would be for example set in the
verify
attribute of the session. Therefore I would see two options:request
instantiated (e.g. I see it inyfinance/data.py
, line 73). This would meen having the session exposed as an attribute for exampleobb.session
, so that its attributes can be modified..env
file which will then picked up when creating arequest.Session()
in a similar manner to what is done for proxies.The text was updated successfully, but these errors were encountered: