Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.1: build process downloads file from public network #131

Open
kloczek opened this issue Jan 25, 2021 · 3 comments
Open

3.0.1: build process downloads file from public network #131

kloczek opened this issue Jan 25, 2021 · 3 comments

Comments

@kloczek
Copy link

kloczek commented Jan 25, 2021

Problem is that many build envs are intentionally cut off from public network.
It would be good provide cmake option allowing extract test data from provided tar ball.

@leej3
Copy link
Collaborator

leej3 commented Jan 25, 2021

You can add -DDOWNLOAD_TEST_DATA=OFF to your cmake command to prevent this issue. The tests should then be run like this (adding -LE NEEDS_DATA to the ctest command) to avoid any tests that require said data.

Your suggested addition of functionality to the cmake system is an elegant solution too though. It would be added around this part of the cmake system. With newer versions of cmake this can be handled far more easily. Implementing the functionality in a manner that is compatible with cmake version 3.11 is a little trickier, but not too bad. A pull request for that is welcome. I'm happy to provide some pointers if required.

@kloczek
Copy link
Author

kloczek commented Jan 25, 2021

You can add -DDOWNLOAD_TEST_DATA=OFF to your cmake command to prevent this issue

Wit that allmost all tests are afailing.

The tests should then be run like this (adding -LE NEEDS_DATA to the ctest command) to avoid any tests that require said data.

And by this only most of the test units are disabled.

Instead implemeting downloadiung those test data IMO those data instead be maintained in separated git repo should be part of thos repo and distributed/tagged with all stupp which depends on those data.
All this effort is only to reduce size of the dist data. IMO all that is pointless and only complicates whole process.

@leej3
Copy link
Collaborator

leej3 commented Jan 25, 2021

Duly noted. There were various constraints that led to this solution. I agree there are other ways that are better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants