Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow title/linktext in links #92

Closed
muescha opened this issue Mar 1, 2020 · 13 comments
Closed

allow title/linktext in links #92

muescha opened this issue Mar 1, 2020 · 13 comments
Labels
enhancement New feature or request needs more info

Comments

@muescha
Copy link

muescha commented Mar 1, 2020

Allow links with title, so that the transformer can use a title if needed:

[Set up a Gatsby site](https://egghead.io/lessons/some-lesson)
@MichaelDeBoey MichaelDeBoey added the enhancement New feature or request label Mar 1, 2020
@MichaelDeBoey
Copy link
Owner

Hi @muescha!

Just to be sure, what's the expected outcome you're looking for? 🤔
And why do you want it so badly?

@muescha
Copy link
Author

muescha commented Mar 1, 2020

for example for the Gatsby EggHeadEmbed Component has it. (see #93)
thats a good way to provide some a title or as an alt tag for aria

@MichaelDeBoey
Copy link
Owner

@muescha Why do you think it's necessary to add it?
What value does it have?

@muescha
Copy link
Author

muescha commented Mar 2, 2020

if has the titele value that this plugin can handle also egghead embeds with a title.

the egghead component uses the title tag (egghead-embed)

but you are right i see one drawback: then it is not that easy to distinct between "real" links and links who are needs to embedded.

@MichaelDeBoey
Copy link
Owner

Yeah the question we also have to ask ourselves is if it really is necessary that we can set a correct title.
I'm not seeing any value in doing so tbh.

Maybe @kentcdodds can sway in with his opinion too? 🤔

@muescha
Copy link
Author

muescha commented Mar 2, 2020

i think it is in the gatsby repo because of accessibility
(https://dequeuniversity.com/tips/provide-iframe-titles)

i think the other transformers can also benefit from more accessibility

@muescha
Copy link
Author

muescha commented Mar 2, 2020

## Other resources

- [Egghead.io Course: Gatsby Theme Authoring (free)](https://egghead.io/courses/gatsby-theme-authoring)
- [Setting up yarn workspaces for Gatsby theme development](/blog/2019-05-22-setting-up-yarn-workspaces-for-theme-development/#reach-skip-nav)
- [What is component shadowing?](/blog/2019-04-29-component-shadowing/)
- [Customizing styles in Gatsby themes with Theme-UI](/blog/2019-07-03-customizing-styles-in-gatsby-themes-with-theme-ui/)
- [Composing and styling Gatsby themes (with Brent Jackson) — Learn With Jason](https://www.youtube.com/watch?v=6Z4p-qjnKCQ)
- [Build a Personal Site Using Gatsby Themes (with Will Johnson) — Learn With Jason](https://www.youtube.com/watch?v=vf2Dy_xKUno)

or in lists like this:
https://github.com/gatsbyjs/gatsby/blob/037006b0f0f6ea57de121917e864a3cb48665a3a/docs/docs/awesome-gatsby-resources.md#L62-L65

@MichaelDeBoey
Copy link
Owner

The list you're providing is just meant to be a list, not all embeds.
So I think the plugin is doing what it should do, no? 🤔

@muescha
Copy link
Author

muescha commented Mar 2, 2020

Sorry I forget to add this:
the examples are against my suggestion. That means adding a title is not a good idea because of the syntax :(

@muescha
Copy link
Author

muescha commented Mar 2, 2020

an other syntax suggestion: maybe with a blockquote >

> [EggHead Lesson: Set up a Gatsby site](https://egghead.io/lessons/some-lesson)

@MichaelDeBoey
Copy link
Owner

an other syntax suggestion: maybe with a blockquote >

What about when people have a quote with a link in it? 🤔

@muescha
Copy link
Author

muescha commented Mar 2, 2020

the same if just the url as text is in a paragraph 🤔

@MichaelDeBoey
Copy link
Owner

That's true indeed.

Going to close this one, as it's clear that this isn't really something that would be possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs more info
Projects
None yet
Development

No branches or pull requests

2 participants