-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow title/linktext in links #92
Comments
Hi @muescha! Just to be sure, what's the expected outcome you're looking for? 🤔 |
for example for the Gatsby EggHeadEmbed Component has it. (see #93) |
@muescha Why do you think it's necessary to add it? |
if has the titele value that this plugin can handle also egghead embeds with a title. the egghead component uses the title tag (egghead-embed) but you are right i see one drawback: then it is not that easy to distinct between "real" links and links who are needs to embedded. |
Yeah the question we also have to ask ourselves is if it really is necessary that we can set a correct title. Maybe @kentcdodds can sway in with his opinion too? 🤔 |
i think it is in the gatsby repo because of accessibility i think the other transformers can also benefit from more accessibility |
## Other resources
- [Egghead.io Course: Gatsby Theme Authoring (free)](https://egghead.io/courses/gatsby-theme-authoring)
- [Setting up yarn workspaces for Gatsby theme development](/blog/2019-05-22-setting-up-yarn-workspaces-for-theme-development/#reach-skip-nav)
- [What is component shadowing?](/blog/2019-04-29-component-shadowing/)
- [Customizing styles in Gatsby themes with Theme-UI](/blog/2019-07-03-customizing-styles-in-gatsby-themes-with-theme-ui/)
- [Composing and styling Gatsby themes (with Brent Jackson) — Learn With Jason](https://www.youtube.com/watch?v=6Z4p-qjnKCQ)
- [Build a Personal Site Using Gatsby Themes (with Will Johnson) — Learn With Jason](https://www.youtube.com/watch?v=vf2Dy_xKUno) or in lists like this: |
The list you're providing is just meant to be a list, not all embeds. |
Sorry I forget to add this: |
an other syntax suggestion: maybe with a blockquote > [EggHead Lesson: Set up a Gatsby site](https://egghead.io/lessons/some-lesson)
|
What about when people have a quote with a link in it? 🤔 |
the same if just the url as text is in a paragraph 🤔 |
That's true indeed. Going to close this one, as it's clear that this isn't really something that would be possible. |
Allow links with title, so that the transformer can use a title if needed:
The text was updated successfully, but these errors were encountered: