Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[error] translate text from english to chinese #3

Open
subineru opened this issue Jul 23, 2023 · 2 comments · Fixed by #6
Open

[error] translate text from english to chinese #3

subineru opened this issue Jul 23, 2023 · 2 comments · Fixed by #6

Comments

@subineru
Copy link

utf8_error

@felladrin
Copy link
Contributor

Hi, @Maknee. Could you recheck this?

I found a reliable way to reproduce this issue:

from huggingface_hub import hf_hub_download
import minigpt4_library

model_path = hf_hub_download(
    repo_id="maknee/minigpt4-13b-ggml",
    filename="minigpt4-13B-f16.bin",
    repo_type="dataset",
)

llm_model_path = hf_hub_download(
    repo_id="maknee/ggml-vicuna-v0-quantized",
    filename="ggml-vicuna-13B-v0-q5_k.bin",
    repo_type="dataset",
)

minigpt4_chatbot = minigpt4_library.MiniGPT4ChatBot(model_path, llm_model_path)

for output in minigpt4_chatbot.generate(
    "tell me about yourself",
    limit=1024,
    temp=0,
    top_k=0,
    top_p=0,
    repeat_penalty=1,
):
    print(output)

Using an emoticon as prompt makes it fail even earlier (it fails before printing anything on the terminal):

for output in minigpt4_chatbot.generate(
     "😀",
    limit=1024,
    temp=0,
    top_k=0,
    top_p=0,
    repeat_penalty=1,
):
    print(output)

I think minigpt4.cpp would require a similar solution like the one applied here:

@Maknee Maknee reopened this Aug 2, 2023
@Maknee
Copy link
Owner

Maknee commented Aug 2, 2023

Thanks @felladrin. Interesting, I'll have to look into this with that PR in mind. Unfortunately, I haven't tested any other input besides english characters/words.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants