Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make logging_mode (on_step or on_epoch) available to loggers #20502

Open
SiddhantSadangi opened this issue Dec 17, 2024 · 0 comments
Open

Make logging_mode (on_step or on_epoch) available to loggers #20502

SiddhantSadangi opened this issue Dec 17, 2024 · 0 comments
Labels
feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers

Comments

@SiddhantSadangi
Copy link
Contributor

SiddhantSadangi commented Dec 17, 2024 •
edited by github-actions bot
Loading

Description & Motivation

Lightning lets you log on_step, or on_epoch. However, even when using on_epoch, the global step is logged on the x-axis, not the epoch number.

Loggers can manually extract epoch from the logged metrics and pass that as the step. However, this would break on_step logging.

Making the logging mode for a logging call available would let loggers conditionally use either the global_step or current_epoch as the step for that particular metric.

Pitch

No response

Alternatives

No response

Additional context

No response

cc @Borda
@SiddhantSadangi SiddhantSadangi added feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SiddhantSadangi