Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token throughput monitor assumes batch size is fixed but does not raise meaningful error #20235

Open
alex-hh opened this issue Aug 29, 2024 · 0 comments · May be fixed by #20236
Open

Token throughput monitor assumes batch size is fixed but does not raise meaningful error #20235

alex-hh opened this issue Aug 29, 2024 · 0 comments · May be fixed by #20236
Labels

Comments

@alex-hh
Copy link

alex-hh commented Aug 29, 2024

Bug description

If using token throughput monitor with variable batch size the samples counter will be incorrect leading to a possibly non-monotonically increasing sample count. Although the docs do say that batch size should be fixed, there is no explicit check for this, leading to an error message that is hard to understand.

e.g. if batch sizes are 1, 2, 1
then samples passed to throughput in update are 1, 4, 3, and a value error is raised:
ValueError: Expected the value to increase, last: 4, current: 3

Is there any reason not to support variable batch size on throughput monitor?

What version are you seeing the problem on?

v2.4

@alex-hh alex-hh added bug Something isn't working needs triage Waiting to be triaged by maintainers labels Aug 29, 2024
@alex-hh alex-hh linked a pull request Aug 29, 2024 that will close this issue
7 tasks
@lantiga lantiga added callback: throughput and removed needs triage Waiting to be triaged by maintainers labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants