Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply the ignore of the save_hyperparameters function to args #19761

Open
doveppp opened this issue Apr 11, 2024 · 3 comments · May be fixed by #20213
Open

Apply the ignore of the save_hyperparameters function to args #19761

doveppp opened this issue Apr 11, 2024 · 3 comments · May be fixed by #20213
Labels
feature Is an improvement or enhancement good first issue Good for newcomers help wanted Open to be worked on

Comments

@doveppp
Copy link

doveppp commented Apr 11, 2024 •
edited by github-actions bot
Loading

Description & Motivation

Currently, the ignore parameter of the save_hyperparameters function only filters its own arguments.

Can we apply hp = {k: v for k, v in hp.items() if k not in ignore} before obj._set_hparams(hp)?

image

Pitch

No response

Alternatives

No response

Additional context

No response

cc @Borda
@doveppp doveppp added feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers labels Apr 11, 2024
@awaelchli awaelchli added help wanted Open to be worked on good first issue Good for newcomers and removed needs triage Waiting to be triaged by maintainers labels Aug 3, 2024
@Borda Borda changed the title Apply the ignore of the save_hyperparameters function to args as well. Apply the ignore of the save_hyperparameters function to args Aug 6, 2024
@aseemk98
Copy link

I'll take this up.

@aseemk98 aseemk98 linked a pull request Aug 19, 2024 that will close this issue
Open
7 tasks
@vgauraha62
Copy link

hey did you resolve this issue?

@22ema
Copy link

22ema commented Dec 18, 2024

I'll take this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Is an improvement or enhancement good first issue Good for newcomers help wanted Open to be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added ignore for hyper params aseemk98/pytorch-lightning
5 participants
@awaelchli @aseemk98 @22ema @doveppp @vgauraha62