Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed support for kube-rbac-proxy in Kubebuilder v4 #399

Open
2 tasks
pmalek opened this issue Jul 5, 2024 · 3 comments · May be fixed by #956
Open
2 tasks

Removed support for kube-rbac-proxy in Kubebuilder v4 #399

pmalek opened this issue Jul 5, 2024 · 3 comments · May be fixed by #956
Assignees
Milestone

Comments

@pmalek
Copy link
Member

pmalek commented Jul 5, 2024

Problem statement

KGO utilizes kube-rbac-proxy for metrics endpoint protection: https://github.com/Kong/gateway-operator/blob/83702a93c24a603bb7219bac09a581af037f8f62/config/default/manager_auth_proxy_patch.yaml

Kubebuilder v4 removes support for that image. Images from gcr.io/kubebuilder/kube-rbac-proxy repo will be available until March 18, 2025.

Proposed solution

In order to keep support for metrics endpoint protection we can

Anything else ?

More information: kubernetes-sigs/kubebuilder#3907

Acceptance criteria

@pmalek pmalek added this to the KGO v1.5.x milestone Dec 5, 2024
@pmalek
Copy link
Member Author

pmalek commented Dec 5, 2024

The data at which gcr.io/kubebuilder/kube-rbac-proxy will become unavailable is slowly approaching.

Let's discuss this on the next sync meeting.

An alternative to using a different image as proposed in the description is to use WithAuthenticationAndAuthorization from controller-runtime. Example of its usage: https://github.com/kubernetes-sigs/kubebuilder/blob/a9ee3909f7686902879bd666b92deec4718d92c9/testdata/project-v4/cmd/main.go#L118-L128

@tao12345666333
Copy link
Member

I want to pick up this one.

@tao12345666333 tao12345666333 self-assigned this Dec 18, 2024
@lahabana
Copy link
Contributor

@tao12345666333 remember that this is done already in: Kong/kubernetes-ingress-controller#6815

@tao12345666333 tao12345666333 linked a pull request Dec 25, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants