Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KDReports::Frame need setMargin functions #25

Open
CMLDMR opened this issue Feb 16, 2021 · 6 comments
Open

KDReports::Frame need setMargin functions #25

CMLDMR opened this issue Feb 16, 2021 · 6 comments

Comments

@CMLDMR
Copy link

CMLDMR commented Feb 16, 2021

QTextFrameFormat class support setMargin functions; Top, Bottom, Right, Left or entire margins.

I implemented new functions to Frame class,

    KDReports::Frame& setTopMargin( qreal topMargin );

    KDReports::Frame& setBottomMargin( qreal bottomMargin );

    KDReports::Frame& setLeftMargin( qreal leftMargin );

    KDReports::Frame& setRightMargin( qreal rightMargin );


    qreal topMargin() const;
    qreal bottomMargin() const;
    qreal leftMargin() const;
    qreal rightMargin() const;

now we can place to element to anywhere at the page.

image

@dfaure-kdab
Copy link
Member

Cool. Can you make a merge request?

@winterz
Copy link
Member

winterz commented Feb 16, 2021

@CMLDMR thanks for helping with KDReports

Keep in mind that we (KDAB) could not accept a patch for this feature without your signature on the Copyright agreement as mentioned in our README. Of course @dfaure-kdab would need to accept the patch first.

Instructions and more info can be found in doc/KDReports-CopyrightAssignmentForm.pdf

@CMLDMR
Copy link
Author

CMLDMR commented Feb 18, 2021

I implemented this and its very usefull and now I am using patched version. I wrote here for benefits to other users.
I dont know very well github (like, pull request ) and what about Copyrights aggreement?

Thanks for Reply.

@dfaure-kdab
Copy link
Member

@CMLDMR Do you still need help with making a pull request, if you're still interested in doing that?

@CMLDMR
Copy link
Author

CMLDMR commented Aug 16, 2021

I created long time ago if it is in right way.

@dfaure-kdab
Copy link
Member

Oh, right, sorry, that's #26
Let's discuss it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants