Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why does the argument order of pyconvert_add_rule deviate from convention #363

Open
LilithHafner opened this issue Sep 20, 2023 · 2 comments · May be fixed by #367
Open

Why does the argument order of pyconvert_add_rule deviate from convention #363

LilithHafner opened this issue Sep 20, 2023 · 2 comments · May be fixed by #367
Labels
question Further information is requested
Milestone
v1

Comments

@LilithHafner
Copy link
Contributor

According to the Julia Docs, function arguments should be placed first because "Putting a function argument first permits the use of do blocks for passing multiline anonymous functions."

Is there a reason for not following this convention?
Would it be reasonable to support the conventional argument order in addition to the current argument order?
Can we switch fully to the conventional argument order and deprecate the current argument order / remove it in the next breaking release?
@LilithHafner LilithHafner added the question Further information is requested label Sep 20, 2023
@cjdoris
Copy link
Collaborator

cjdoris commented Sep 21, 2023

No particular reason. It started life as a non-API function. I'll consider this for v1 - the pyconvert machinery is going to be overhauled anyway.

@cjdoris cjdoris added this to the v1 milestone Sep 21, 2023
@cjdoris
Copy link
Collaborator

cjdoris commented Sep 21, 2023

Feel free to make a PR to add a version with the function-first order.

@LilithHafner LilithHafner linked a pull request Sep 21, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
v1
Development

Successfully merging a pull request may close this issue.

Switch argument order of pyconvert_add_rule LilithHafner/PythonCall.jl
2 participants
@cjdoris @LilithHafner