Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring to different loggers #23

Open
Arkoniak opened this issue Aug 8, 2021 · 2 comments
Open

Refactoring to different loggers #23

Arkoniak opened this issue Aug 8, 2021 · 2 comments
Assignees

Comments

@Arkoniak
Copy link
Collaborator

Arkoniak commented Aug 8, 2021

It seems that as more and more loggers are being added, current scheme (of single logger with multiple options) becoming less and less manageable and more and more confusing.

Instead, I propose to introduce following four loggers:

  1. ProstLogger - basic version of the logger, without any additional transformations. (Name is chosen slightly confusing, so people are less inclined to use it)
  2. SquashLogger - improved version of ProstLogger, which squashes multilines messages to a single line
  3. MarkdownLogger - markdown version of ProstLogger.
  4. JsonLogger - logger, which saves all data in json lines.

This way, we will really get collection of loggers (and package name will be more meaningful) and also it will be easier to setup config options.

As a possible generous gesture, all loggers can accept all keywords, just useless keywords will go undocumented.

@Arkoniak Arkoniak self-assigned this Aug 8, 2021
@Arkoniak
Copy link
Collaborator Author

Arkoniak commented Aug 9, 2021

After some consideration, I decided to go with 3 Loggers only

  1. MiniLogger (this is a combination of SquashLogger and ProstLogger from the proposal). There are two motivations behind this decision. First of all, I do not want to break things too much. Secondly, this squash thing can be applied to JsonLogger and MarkdownLogger, so there is no need to distinguish them.
  2. MarkdownLogger - which should probably be upgraded to support HTML tags to some extent
  3. JsonLogger

They all should share same arguments, but default settings can be different.

@cossio
Copy link

cossio commented Apr 28, 2022

I actually like the current MiniLogger, having all the options available together can make things more easily accessible for the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants