Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eagerly convert to Array type before sending to IO backend #45

Merged
merged 3 commits into from
Oct 22, 2021
Merged

eagerly convert to Array type before sending to IO backend #45

merged 3 commits into from
Oct 22, 2021

Conversation

johnnychen94
Copy link
Member

This avoids JuliaIO/PNGFiles.jl#43 but we should also do the same in PNGFiles.jl

closes #39
closes #40

cc: @tlnagy

@codecov
Copy link

codecov bot commented Oct 22, 2021 •
edited
Loading

Codecov Report

Merging #45 (9c0b248) into master (953f8e6) will increase coverage by 1.38%.
The diff coverage is 100.00%.

❗ Current head 9c0b248 differs from pull request most recent head f5b4be0. Consider uploading reports for the commit f5b4be0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage   87.20%   88.58%   +1.38%     
==========================================
  Files           6        6              
  Lines         211      219       +8     
==========================================
+ Hits          184      194      +10     
+ Misses         27       25       -2
Impacted Files Coverage Δ
src/showmime.jl 98.68% <100.00%> (+1.50%) ⬆️
src/multipage.jl 81.81% <0.00%> (+0.56%) ⬆️
src/keyboard.jl 81.63% <0.00%> (+2.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 953f8e6...f5b4be0. Read the comment docs.

@johnnychen94
test: add ImageIO backend
ae5c6c7 
The current ImageMagick version for Julia >= 1.3 is a bit broken for PNG files
because the built ImageMagick_jll is broken.
JuliaIO/ImageMagick.jl#206

This commit work arounds this bug by adding ImageIO dependency.
Because ImageIO has higher priority in the FileIO registry, it will
use the PNGFiles to load the data instead of using the broken
ImageMagick.
@johnnychen94
ImageShow v0.3.3
f5b4be0
@johnnychen94 johnnychen94 changed the title eagerly convert Array type before sending to IO backend eagerly convert to Array type before sending to IO backend Oct 22, 2021
@johnnychen94 johnnychen94 merged commit 43fab62 into master Oct 22, 2021
@johnnychen94 johnnychen94 deleted the jc/array branch October 22, 2021 09:22
@johnnychen94 johnnychen94 mentioned this pull request Oct 22, 2021
Merged
@johnnychen94 johnnychen94 mentioned this pull request Nov 2, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failed to show image in CUDA devices AxisArray support
1 participant
@johnnychen94