-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency on Images.jl directly #46
Comments
A worthy discussion point, though one that seems unlikely to have a unique answer. The JuliaImages ecosystem could be organized in a variety of ways:
Right now we're closest to the third. In many ways I think the third makes a certain amount of sense, with one big caveat: I'm not aware of any principle that defines what should or should not be in the common core. In practice it has largely been defined by history: what got put into Images.jl before the creation of the JuliaImages organization and the splitting out of much of the functionality to more focused packages. At the time I did the big 0.6 rewrite, I decided not to be breaking and to make sure that Images re-exported the functionality that had been moved to other packages. Right now the two big outsider packages (EDIT: of those hosted at JuliaImages) are ImageFeatures and ImageSegmentation, both focused on computer-vision type applications. (Here I'm not counting visualization packages.) |
With regards to specifically whether this needs to depend on all of Images, probably not. I suspect the keypoints->corners->edges dependency would be the main one. |
That makes sense. The one thing that makes this situation a little awkward to explain to a end-user, is that just typing I say this because displaying images in Jupyter without the custom show code in Images.jl works just well enough to confuse users, but its basically a showstopper. |
Yeah, it might be worth moving to an |
One thing we are sure of is that Since this is the case, Then the role of
Minimal or maximal, it really doesn't make much difference when composing modules becomes an easy work. Possibly we could build up our packages just like we build up a docker image. |
I realize this may be an odd question.
It came up in JuliaImages/Images.jl#682 (comment) that
ImageFeatures.jl
depends onImages.jl
, and I found this quite surprising because my mental image forImages.jl
so far was as a convenient meta package for importing the whole ecosystem.So I just felt like double checking this wouldn't hurt. Is there a reason that this package needs to depend on
Images.jl
directly, instead of the individual backend packages? I quickly browsed through the source files and didn't see any obvious reason like extending a function.The text was updated successfully, but these errors were encountered: