Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plot.jl to account for line style #131

Closed
wants to merge 0 commits into from

Conversation

davide-f
Copy link

@davide-f davide-f commented Nov 1, 2020

Hi,

This commit resolves #127

Regards,
Davide

@codecov
Copy link

codecov bot commented Nov 1, 2020

Codecov Report

Merging #131 into master will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
+ Coverage   33.26%   33.39%   +0.12%     
==========================================
  Files           9        9              
  Lines         526      527       +1     
==========================================
+ Hits          175      176       +1     
  Misses        351      351              
Impacted Files Coverage Δ
src/plot.jl 62.50% <100.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ce59f9...387d1a9. Read the comment docs.

@davide-f
Copy link
Author

It seems like there are some pull requests pending; do you see that they will be investigated and completed in the foreseable future?
Thank you,
Davide

@hdavid16
Copy link
Contributor

@simonschoelly, did this PR fall through the cracks?

@etiennedeg
Copy link
Member

oops, I messed something up...

@etiennedeg
Copy link
Member

I tried to rebase the PR and add a commit withsome documentation about it, but that didn't worked as expected. Maybe I should try reopening a PR.

@etiennedeg
Copy link
Member

Ok, I think I understand what happened: the PR was on master, and I already add a master branch created. so when I fetched it, it renamed the branch, and when I pushed, it pushed my master instead of the modifications. Sorry about that, I will make a new PR.

@etiennedeg
Copy link
Member

new PR: #176

@simonschoelly
Copy link
Member

git rebase -i + force push afterwards might help in such situtations

@etiennedeg
Copy link
Member

I think this is what I did, but I pushed the master instead of the PR branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashed edges?
4 participants