Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to integrate Meshes.jl geometries that aren't parameterized #28

Open
4 of 8 tasks
mikeingold opened this issue Mar 3, 2024 · 6 comments
Open
4 of 8 tasks

Unable to integrate Meshes.jl geometries that aren't parameterized #28

mikeingold opened this issue Mar 3, 2024 · 6 comments
Labels
enhancement New feature or request upstream Requires action in a dependency package

Comments

@mikeingold
Copy link
Collaborator

mikeingold commented Mar 3, 2024 •
edited
Loading

Some Meshes.jl geometries are not yet supported because they lack parametric functions, i.e. (::Geometry)(ts...) -> ::Point.

  • Cone
  • ConeSurface
  • Cylinder
  • Frustum
  • FrustumSurface
  • Polyarea
  • Pyramid
  • Wedge

If these functions can be added to Meshes.jl then we should be capable of integrating these.
@mikeingold mikeingold added enhancement New feature or request question Further information is requested labels Mar 3, 2024
@mikeingold mikeingold changed the title Some Meshes.jl geometry types not yet parameterized Unable to integrate Meshes.jl geometries not yet parameterized Mar 13, 2024
@mikeingold
Copy link
Collaborator Author

mikeingold commented Mar 18, 2024 •
edited
Loading

Meshes.jl just merged a PR I wrote adding a parameterization function for Cylinder.

Update: integration over a Cylinder is verified working as of #30

@mikeingold
Copy link
Collaborator Author

Looks like a recent update to Meshes.jl also added a parameterization function for ConeSurface, so this should now be implementable.

@mikeingold mikeingold changed the title Unable to integrate Meshes.jl geometries not yet parameterized Unable to integrate Meshes.jl geometries that lack parameterization functions Apr 14, 2024
@mikeingold
Copy link
Collaborator Author

Updates (14 Aug 2024):

  • Meshes.jl support for parameterized FrustumSurface was implemented in JuliaGeometry/Meshes.jl@b387402
  • The Cone and Frustum geometries still lack parameterizations.
  • Dropped bullet point about lacking a parameterization for Ball in (>3)-D space -- probably too esoteric to matter

@mikeingold mikeingold pinned this issue Aug 14, 2024
@mikeingold
Copy link
Collaborator Author

I added support for parametric Cones to Meshes.jl as of v0.50

@mikeingold mikeingold changed the title Unable to integrate Meshes.jl geometries that lack parameterization functions Unable to integrate Meshes.Frustum (no parametric function provided) Aug 30, 2024
@mikeingold mikeingold unpinned this issue Aug 30, 2024
@mikeingold
Copy link
Collaborator Author

Closing in favor of #57

@mikeingold mikeingold reopened this Oct 9, 2024
This was referenced Oct 9, 2024
Closed
Merged
@mikeingold mikeingold changed the title Unable to integrate Meshes.Frustum (no parametric function provided) Unable to integrate Meshes.jl geometries that lack parameterization functions Oct 11, 2024
@mikeingold mikeingold added bug Something isn't working and removed question Further information is requested labels Nov 8, 2024
@mikeingold
Copy link
Collaborator Author

Update: There’s been no status change to the remaining four geometry types. All still lack parametric functions, so cannot be integrated.

@mikeingold mikeingold changed the title Unable to integrate Meshes.jl geometries that lack parameterization functions Unable to integrate Meshes.jl geometries that aren't parameterized Nov 30, 2024
@mikeingold mikeingold added upstream Requires action in a dependency package and removed bug Something isn't working labels Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request upstream Requires action in a dependency package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mikeingold